WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #18268, comment 18


Ignore:
Timestamp:
06/13/12 15:51:54 (3 years ago)
Author:
georgestephanis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18268, comment 18

    initial v1  
    11Just added a modification of the `wp_allowed_protocols()` function -- as-is, if you call the function once, say, in a plugin for whatever reason, the static is set and the filter triggers, and no other plugins / theme stuff / whatever will be able to add a filter, as empty() will always be false. 
    22 
    3 I like optimizing things as much as the next guy and caching it with static, but we could potentially be caching bad data. 
     3I like optimizing things as much as the next guy and caching it with static, but we could potentially be caching incomplete data. 
    44 
    55Perhaps leave it as a static, and call doing_it_wrong() if they activate it before a certain point, to ensure everyone at the table has an opportunity to attach filters?