WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 15 months ago

#18287 new enhancement

wp-login.php - Logo URL should be relative (affects MultiSite)

Reported by: Ipstenu Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.2.1
Component: Login and Registration Keywords: has-patch ux-feedback
Focuses: multisite Cc:

Description

If you go to your domain.com/wp-login.php page it has a WP logo that links back to domain.com

If you're using multisite and go to subsite.domain.com/wp-login.php, it links back to domain.com

If you're using multisite and you MAP a domain and go to mappeddomain.com/wp-login.php, it links back to domain.com

I can see why this would have been done. It points to network_home_url() which is perfectly sensible for MOST situations. But maybe we should just honor the site on which people are trying to login, so that it's all relative. Given the link on the bottom (back to...) goes to the relative site, this is a logical change. I would say to keep the EMAILS for password resets as is, since the network is in charge of it all, but the front end interface should be consistant.

I did a quick test and this works fine on Single and Multi (as expected). So ... here's my first diff!

Attachments (2)

relative-wp-login.diff (1.0 KB) - added by Ipstenu 4 years ago.
relative URL on wp-login, for MultiSite.
18287.patch (1.5 KB) - added by SergeyBiryukov 4 years ago.
with home_url()

Download all attachments as: .zip

Change History (17)

@Ipstenu4 years ago

relative URL on wp-login, for MultiSite.

comment:1 @SergeyBiryukov4 years ago

  • Keywords has-patch added

Shouldn't it be home_url(), for proper SSL support?

comment:2 @Ipstenu4 years ago

The backtoblog link doesn't, so I wasn't sure which ideology would take precedence and went with what's in the more obvious link (I didn't even realize the logo was linked until yesterday). Clearly, it's just as easy a fix either way.

comment:3 @SergeyBiryukov4 years ago

  • Keywords ui-feedback added

@SergeyBiryukov4 years ago

with home_url()

comment:4 @SergeyBiryukov3 years ago

  • Keywords ux-feedback added; ui-feedback removed

comment:5 @bpetty2 years ago

Makes sense to me that this would link to the home_url() rather than the network home.

Kind of a shame to see such a simple ticket like this sit for 18 months with no attention.

comment:6 @SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.6

comment:7 @nacin2 years ago

  • Type changed from defect (bug) to enhancement

For single-site, it links to http://wordpress.org. For multi-site — given its open registration multi-user history — it links to the network's home.

Based on the single-site behavior, it certainly seems to make sense as-is. There's also a "Back to site" link on the same page, which would become redundant with this change.

I'm fine with a re-think here, but note this isn't just a simple bug-fix.

comment:8 follow-up: @Ipstenu2 years ago

Interesting, why does single point to WordPress.org at all?

Seems like they should all point to the same place, and be filterable so a network could change easily it if they wanted.

comment:9 in reply to: ↑ 8 ; follow-up: @rmccue2 years ago

Replying to Ipstenu:

Interesting, why does single point to WordPress.org at all?

That's a very good question. It has always seemed like a weird quirk to me personally. +1 for changing across the board.

comment:10 @mindctrl2 years ago

  • Cc mindctrl added

comment:11 in reply to: ↑ 9 @gazouteast2 years ago

  • Cc gazouteast added

Replying to rmccue:

Replying to Ipstenu:

Interesting, why does single point to WordPress.org at all?

That's a very good question. It has always seemed like a weird quirk to me personally. +1 for changing across the board.

I'm assuming that it links to wp.org because it's the WordPress logo carrying the link.

If the link is to point at network home, then there should be a method to distribute the network home's logo to the wp-login and replace the WordPress logo.

If the link is to point to point to network site home, then there should be a logo from network site that replaces the WordPress logo.

If not, you just know that eventually someone will try using that "accustomed behaviour" of clicking on the WP logo to go to wp.org to create a fake wp.org site (for what ever malevolent or mischevious reason).

An option for site branding / logo could be added to Settings - General.
It's just an instruction to upload a logo of particular dimensions, and if not null, then point to the site/network home. Network admins should have option to decide if network logo & link overrides sub-sites' logos and links (thus switching off the option in sub sites).

comment:12 @DrewAPicture2 years ago

  • Keywords dev-feedback added

Seems like there's still some disagreement on whether (A) The link should be consistent for both single and multisite, and (B) Whether we should be linking to WordPress.org or home_url() which feeds back in to (A). Maybe we should punt this and hash it out in 3.7.

comment:13 @ipstenu2 years ago

I would say it should like to WordPress for everyone, since that is an understandable expectation based on Single.

Since you can already replace the logo - http://wordpress.org/extend/plugins/login-logo/ - we'll need to make sure that we can replace on the fly (Then Mark's logo would be a perfect way to change the logo from Generic WP to your site, with a link back to Your Site :) )

comment:14 @nacin2 years ago

  • Keywords dev-feedback removed
  • Milestone changed from 3.6 to Future Release

There are already filters in place, so yes, replacement is doable.

I agree with not dealing with this now. Maybe a combination of some multisite work and possibly MP6 in 3.7/8 could allow us to revisit.

comment:15 @jeremyfelt15 months ago

  • Component changed from Administration to Login and Registration
  • Focuses multisite added
Note: See TracTickets for help on using tickets.