Make WordPress Core

Opened 4 years ago

Last modified 20 months ago

#18292 new enhancement

Not interrupting the network update, even if errors are detected

Reported by: luuzan@… Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.2.1
Component: Upgrade/Install Keywords: has-patch
Focuses: multisite Cc:


My installation
3.2.1 multi-site installation with almost 8000 sites.

The issue
During the network update, I kept getting this error message :
Warning! Problem updating http://username.example.com. Your server may not be able to connect to sites running on it. Error message: 0: Empty reply from server.
The problem is that the network update script (/wp-admin/network/upgrade.php) dies every time an error is detected, so I had to reload the page every time. With nearly 8000 sites to update, it was impossible, so I modified that script.

Suggested enhancement
Enhance the network update script so that it doesn't die at each error, logs the error and continues. A second run on the unsuccessful upgrades would also be nice.

Attachments (1)

18292.patch (1.6 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 @ocean904 years ago

Related: #11869

comment:2 @luuzan@…4 years ago

And what would be even sweater is the possibility to choose

  • the batch size : upgrade 5 blogs at once or 10, 20, etc
  • the timeout of the requests : 120 seconds or 300 seconds, etc

In my case, what seemed to have solved to problem is increasing the timeout to 300 seconds.

comment:3 @SergeyBiryukov4 years ago

  • Keywords needs-patch added

@SergeyBiryukov4 years ago

comment:4 @SergeyBiryukov4 years ago

  • Keywords has-patch added; needs-patch removed

18292.patch would allow to continue updating the remaining sites.

Doesn't touch UI, leaving that for #11869.

comment:5 @SergeyBiryukov4 years ago

  • Component changed from Upgrade/Install to Multisite

comment:6 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.4

comment:7 @bigdawggi4 years ago

  • Cc matt@… added

comment:8 @nacin3 years ago

The problem is that doing this will still cause the JS to fire, which means you'll only see the error message if you're paying attention. We really should just implement #11869.

comment:9 @ryan3 years ago

  • Milestone changed from 3.4 to Future Release

comment:10 @jeremyfelt20 months ago

  • Component changed from Multisite to Upgrade/Install
  • Focuses multisite added
Note: See TracTickets for help on using tickets.