WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#18293 closed defect (bug) (fixed)

site_url() used instead of home_url()

Reported by: johnbillion Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.2.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

There's a couple of places where home_url() should be used instead of site_url(). Patch coming up.

Attachments (1)

18293.patch (2.4 KB) - added by johnbillion 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 ocean903 years ago

  • Keywords needs-patch added

comment:2 ocean903 years ago

  • Keywords reporter-feedback added

Where are the places?

comment:3 johnbillion3 years ago

  • Keywords reporter-feedback removed

Oops, this slipped my mind. Patch coming up. Nothing major.

johnbillion3 years ago

comment:4 johnbillion3 years ago

  • Keywords has-patch added; needs-patch removed
  • Version set to 3.2.1

Patch replaces a few occurrences of site_url() with home_url().

Background: site_url() returns a URL with an https protocol for sites that use administration over SSL. home_url() returns the home URL with the correct protocol.

comment:5 ryan2 years ago

  • Milestone changed from Awaiting Review to 3.4

comment:6 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19674]:

Use home_url() instead of site_url(). Props johnbillion. fixes #18293

comment:7 ryan2 years ago

In [19676]:

Use home_url() instead of site_url(). Props johnbillion. fixes #18293

Note: See TracTickets for help on using tickets.