Make WordPress Core

Opened 13 years ago

Closed 9 years ago

Last modified 9 years ago

#18297 closed defect (bug) (invalid)

Cropping in step 2 in Custom_Image_Header

Reported by: wpsmith's profile wpsmith Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.2.1
Component: Media Keywords:
Focuses: Cc:

Description

The cropping should not be based on the ratio but should follow some basic logic.

if ( ( yimg < HEADER_IMAGE_HEIGHT ) && ( ximg < HEADER_IMAGE_WIDTH ) ) no crop
else
do follow current functionality

Attachments (1)

custom_header.patch (1.9 KB) - added by wpsmith 13 years ago.

Download all attachments as: .zip

Change History (14)

#1 @wpsmith
13 years ago

So the JS could be:

if (yimg > yint) && (ximg > xinit) {
			if ( yimg < yinit || ximg < xinit ) {
				if ( ximg / yimg > ratio ) {
					yinit = yimg;
					xinit = yinit * ratio;
				} else {
					xinit = ximg;
					yinit = xinit / ratio;
				}
			}
		}

#2 @wpsmith
13 years ago

So the PHP in function step_2 ():

Replace

if ( $width == HEADER_IMAGE_WIDTH && $height == HEADER_IMAGE_HEIGHT ) {

with

if ( ( $width == HEADER_IMAGE_WIDTH && $height == HEADER_IMAGE_HEIGHT ) || ( ( $width < HEADER_IMAGE_WIDTH && $height < HEADER_IMAGE_HEIGHT ) ) ) {

#3 @wpsmith
13 years ago

And then in step_1():

Replace

<div id="headimg" style="max-width:<?php echo HEADER_IMAGE_WIDTH; ?>px;height:<?php echo HEADER_IMAGE_HEIGHT; ?>px;background-image:url(<?php esc_url ( header_image() ) ?>);">

with

<div id="headimg" style="max-width:<?php echo HEADER_IMAGE_WIDTH; ?>px;height:<?php echo HEADER_IMAGE_HEIGHT; ?>px;background:url(<?php esc_url ( header_image() ) ?>) top left no-repeat;">

#4 @wpsmith
13 years ago

  • Cc travis@… added
  • Component changed from General to Media
  • Keywords has-patch added

#5 @wpsmith
13 years ago

Custom Image now works well in my sandbox in WP 3.2.1.

#6 @mfields
13 years ago

  • Keywords dev-feedback added; has-patch removed

#7 @wpsmith
13 years ago

  • Keywords has-patch added

#8 @coffee2code
12 years ago

  • Keywords needs-refresh added; has-patch removed
  • Version set to 3.2.1

Patch no longer applies cleanly against trunk (currently r20711).

When refreshing the patch, the diff used to produce the patch should be run from the root of the WP install and not a sub-directory.

#10 @ericlewis
10 years ago

  • Keywords reporter-feedback added; dev-feedback removed

@wpsmith, can you explain the problem you're solving here? It's been long enough that I can't comprehend the issue readily, which leans me toward thinking this was fixed sometime in the interim.

#11 @afercia
9 years ago

  • Keywords close added

Last patch is from 4 years ago, no feedback or activity in the last 18 months. @ericlewis I'd suggest to consider closing this ticket :)

#12 @ericlewis
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing out from lack of direction and activity. Feel free to re-open with more details.

#13 @ericlewis
9 years ago

  • Keywords needs-refresh reporter-feedback close removed
Note: See TracTickets for help on using tickets.