Cropping in step 2 in Custom_Image_Header

[wpsmith]

The cropping should not be based on the ratio but should follow some basic logic.

if ( ( yimg < HEADER_IMAGE_HEIGHT ) && ( ximg < HEADER_IMAGE_WIDTH ) ) no crop
else do follow current functionality

[wpsmith]

So the JS could be:

if (yimg > yint) && (ximg > xinit) {
			if ( yimg < yinit || ximg < xinit ) {
				if ( ximg / yimg > ratio ) {
					yinit = yimg;
					xinit = yinit * ratio;
				} else {
					xinit = ximg;
					yinit = xinit / ratio;
				}
			}
		}

[wpsmith]

So the PHP in function step_2 ():

Replace

if ( $width == HEADER_IMAGE_WIDTH && $height == HEADER_IMAGE_HEIGHT ) {

with

if ( ( $width == HEADER_IMAGE_WIDTH && $height == HEADER_IMAGE_HEIGHT ) || ( ( $width < HEADER_IMAGE_WIDTH && $height < HEADER_IMAGE_HEIGHT ) ) ) {

[wpsmith]

And then in step_1():

Replace

<div id="headimg" style="max-width:<?php echo HEADER_IMAGE_WIDTH; ?>px;height:<?php echo HEADER_IMAGE_HEIGHT; ?>px;background-image:url(<?php esc_url ( header_image() ) ?>);">

with

<div id="headimg" style="max-width:<?php echo HEADER_IMAGE_WIDTH; ?>px;height:<?php echo HEADER_IMAGE_HEIGHT; ?>px;background:url(<?php esc_url ( header_image() ) ?>) top left no-repeat;">

[wpsmith]

Custom Image now works well in my sandbox in WP 3.2.1.

[coffee2code]

Patch no longer applies cleanly against trunk (currently r20711).

When refreshing the patch, the diff used to produce the patch should be run from the root of the WP install and not a sub-directory.

[SergeyBiryukov]

Related: #20555, #20657

[ericlewis]

@wpsmith, can you explain the problem you're solving here? It's been long enough that I can't comprehend the issue readily, which leans me toward thinking this was fixed sometime in the interim.

[afercia]

Last patch is from 4 years ago, no feedback or activity in the last 18 months. @ericlewis I'd suggest to consider closing this ticket :)

[ericlewis]

Closing out from lack of direction and activity. Feel free to re-open with more details.