WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 23 months ago

#18297 new defect (bug)

Cropping in step 2 in Custom_Image_Header

Reported by: wpsmith Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.2.1
Component: Media Keywords: dev-feedback needs-refresh
Focuses: Cc:

Description

The cropping should not be based on the ratio but should follow some basic logic.

if ( ( yimg < HEADER_IMAGE_HEIGHT ) && ( ximg < HEADER_IMAGE_WIDTH ) ) no crop
else
do follow current functionality

Attachments (1)

custom_header.patch (1.9 KB) - added by wpsmith 3 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 wpsmith3 years ago

So the JS could be:

if (yimg > yint) && (ximg > xinit) {
			if ( yimg < yinit || ximg < xinit ) {
				if ( ximg / yimg > ratio ) {
					yinit = yimg;
					xinit = yinit * ratio;
				} else {
					xinit = ximg;
					yinit = xinit / ratio;
				}
			}
		}

comment:2 wpsmith3 years ago

So the PHP in function step_2 ():

Replace

if ( $width == HEADER_IMAGE_WIDTH && $height == HEADER_IMAGE_HEIGHT ) {

with

if ( ( $width == HEADER_IMAGE_WIDTH && $height == HEADER_IMAGE_HEIGHT ) || ( ( $width < HEADER_IMAGE_WIDTH && $height < HEADER_IMAGE_HEIGHT ) ) ) {

comment:3 wpsmith3 years ago

And then in step_1():

Replace

<div id="headimg" style="max-width:<?php echo HEADER_IMAGE_WIDTH; ?>px;height:<?php echo HEADER_IMAGE_HEIGHT; ?>px;background-image:url(<?php esc_url ( header_image() ) ?>);">

with

<div id="headimg" style="max-width:<?php echo HEADER_IMAGE_WIDTH; ?>px;height:<?php echo HEADER_IMAGE_HEIGHT; ?>px;background:url(<?php esc_url ( header_image() ) ?>) top left no-repeat;">

comment:4 wpsmith3 years ago

  • Cc travis@… added
  • Component changed from General to Media
  • Keywords has-patch added

comment:5 wpsmith3 years ago

Custom Image now works well in my sandbox in WP 3.2.1.

comment:6 mfields3 years ago

  • Keywords dev-feedback added; has-patch removed

wpsmith3 years ago

comment:7 wpsmith3 years ago

  • Keywords has-patch added

comment:8 coffee2code2 years ago

  • Keywords needs-refresh added; has-patch removed
  • Version set to 3.2.1

Patch no longer applies cleanly against trunk (currently r20711).

When refreshing the patch, the diff used to produce the patch should be run from the root of the WP install and not a sub-directory.

Note: See TracTickets for help on using tickets.