WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 months ago

#18301 accepted enhancement

Activating a new theme on multisite is very long-winded

Reported by: johnbillion Owned by: PeteMall
Milestone: Future Release Priority: normal
Severity: normal Version: 3.1
Component: Themes Keywords: needs-ui
Focuses: ui, multisite Cc:

Description

Scenario:

I've just uploaded a new theme to my theme directory and I now want to activate it on a site. I head to the Appearance › Themes menu for that site and, whoops, I forgot to activate it on the network first. Now I need to:

  1. Click my name in the header
  2. Click Network Admin in the dropdown menu
  3. Click Sites
  4. Find the site and click Edit
  5. Click Themes

From there I can enable the theme.

We're not done yet though. We need to traverse a minimum of two screens to get back to the Themes menu of the site (even more if the admin bar isn't enabled) in order to activate it.

Two things would make this process easier:

  1. A link from the Themes screen to the Themes tab of the site in network admin, so five clicks become one.
  2. The ability to activate a theme from the Themes tab of the site in network admin.

Attachments (3)

18301.diff (1.2 KB) - added by PeteMall 3 years ago.
Activate themes form the network admin site-themes page.
activate_site-themes.png (186.4 KB) - added by PeteMall 3 years ago.
18301.2.patch (747 bytes) - added by betzster 16 months ago.
Network admins can see all themes

Download all attachments as: .zip

Change History (25)

comment:1 johnbillion3 years ago

I might patch this up in the next day or two if I'm not too busy.

comment:2 follow-up: kawauso3 years ago

I've always thought it would be a lot easier if the Super Admin just wasn't subject to the per-site theme restrictions and upon activating, the theme was added to the per-site allowed option. Might be a bit inconsistent though.

comment:3 SergeyBiryukov3 years ago

  • Keywords ux-feedback added

comment:4 in reply to: ↑ 2 johnbillion3 years ago

Replying to kawauso:

I've always thought it would be a lot easier if the Super Admin just wasn't subject to the per-site theme restrictions and upon activating, the theme was added to the per-site allowed option. Might be a bit inconsistent though.

Yeah this crossed my mind, but it might make it unclear to the network admin which themes are enabled (for normal admins) on the current site and which aren't.

Last edited 3 years ago by johnbillion (previous) (diff)

comment:5 scribu3 years ago

Another idea:

If you're on the themes admin page, the Network Admin link sends you to the network themes admin page (and then the Site Admin link sends you back).

This could be done for plugins as well.

Last edited 3 years ago by scribu (previous) (diff)

comment:6 ocean903 years ago

Related: #17099

PeteMall3 years ago

Activate themes form the network admin site-themes page.

comment:7 PeteMall3 years ago

  • Component changed from Multisite to Network Admin
  • Milestone changed from Awaiting Review to 3.3
  • Owner set to PeteMall
  • Status changed from new to accepted
  • Version set to 3.1

comment:8 johnbillion3 years ago

  • Keywords ui-feedback added

Pete, that patch needs some logic so the "activate" link doesn't show up for the active theme.

Should we also display the currently active theme at the top of that screen? It's only displayed on the "Info" tab at the moment.

comment:9 follow-up: jane3 years ago

  • Keywords needs-ui added; ux-feedback ui-feedback removed

"If you're on the themes admin page, the Network Admin link sends you to the network themes admin page (and then the Site Admin link sends you back)." << I'd rather those links always go to the same place for consistency instead of switching on the fly. If you want to write a plugin that implements your suggestion, we could do some testing and see if it performs better (and if so, would consider the switch).

I think having Enable and Activate might be confusing, as enable as a regular word (vs a specific WP term) means something very similar. I also wonder how different those two words are once we get into translations. Maybe we should rethink one or both of those labels.

"Should we also display the currently active theme at the top of that screen? It's only displayed on the "Info" tab at the moment." << That sounds like a good idea. Or maybe highlight the active theme within the table. I can post to UI group to see if anyone wants to mock up an 'active' state.

comment:10 in reply to: ↑ 9 scribu3 years ago

Replying to jane:

"If you're on the themes admin page, the Network Admin link sends you to the network themes admin page (and then the Site Admin link sends you back)." << I'd rather those links always go to the same place for consistency instead of switching on the fly. If you want to write a plugin that implements your suggestion, we could do some testing and see if it performs better (and if so, would consider the switch).

Here you go: https://gist.github.com/1208492

If you're on the themes/plugins/users screen, it will send you to the equivalent network/admin screen.

Here's what it looks like:

http://i.imgur.com/8c5tY.png

I'm completely open to ideas regarding positioning and styling.

comment:11 follow-up: Ipstenu3 years ago

"I think having Enable and Activate might be confusing..."

It is for NES, I know for sure. Andrea and I have already had a couple rounds explaining that one means to make available and one to turn on :/ People complain already about the two words.

Activate - Make available
Enable - Turn on

Barely makes sense to me and I (supposedly) speak English.

comment:12 in reply to: ↑ 11 jane3 years ago

Replying to Ipstenu:

Activate - Make available
Enable - Turn on

Isn't it the other way around? Enable makes it available, Activate turns it on on the live site?

Thinking maybe "Allow" instead of "Enable"?

Activate then would be clearer (Make Active), but other options for the label could be "Choose," "Select," "Use this Theme," "Turn On," "Switch and Publish," etc.

comment:13 follow-up: Ipstenu3 years ago

Yeah, that's why everyone's confused.

If I "network activate" a theme, it becomes available for use on all sites but it does not become the default theme for any of them. It's just there, ready to be used.

If I go to Network Admin -> Sites -> Edit -> Themes, I can "enable" a theme for a site, which does ... the same thing! Makes it available for use!

And then if I go to Site -> WP Admin -> Themes, I can "activate" a theme on that site and NOW it's being used, huzzah!

There's no way to logically handle both 'network activate' and per-site activate on the Network Admin -> Themes page, so leaving that alone for now, the Network Admin -> Sites -> Edit -> Themes page should remove 'Enable' and just name it 'Activate', at the very least for consistencies sake. Then a 'Use This Theme' would be fine. I suspect the brain-breaking was from trying to have a clean, short, explanation.

(Though now I wonder if there mightn't be a need to have a 'Make Default' on the Network Admin -> Themes page ... So people don't have to edit the wp-config.php)

comment:14 in reply to: ↑ 13 SergeyBiryukov3 years ago

Replying to Ipstenu:

If I "network activate" a theme, it becomes available for use on all sites but it does not become the default theme for any of them. It's just there, ready to be used.

Isn't that "Network Enable"?

comment:15 Ipstenu3 years ago

Hmm. It is now. It WAS network Activate (in ... 3.1, I have an old screenshot from a confused Francophile). Looking at 3.3 svn r18660 it's 'Enable.'

Enable and Activate are still too close in terminology to be used on the different theme pages, IMO.

comment:16 scribu3 years ago

I suggest a new ticket is created for the "enable" vs. "activate" debate.

The focus of this ticket should be the fact that it takes 5 steps to set up a new theme on MultiSite.

Last edited 3 years ago by scribu (previous) (diff)

comment:17 scribu3 years ago

So, regarding my Network Quick-switch plugin:

If you're on /blog-x/themes and you click "Network Admin", you are sent to the network admin. But afterwards, you are not sent back to /blog-x/themes, but to /main-blog/themes.

In order to make this work as expected, a cookie would have to be used or an URL parameter, both of which are pretty fragile solutions, so I'm dropping the idea.

Last edited 3 years ago by scribu (previous) (diff)

comment:19 ryan3 years ago

  • Milestone changed from 3.3 to Future Release

Punting enhancements from 3.3.

comment:20 betzster16 months ago

  • Cc j@… added

I think it would be easier if network admins could just activate any theme

betzster16 months ago

Network admins can see all themes

comment:21 Ipstenu16 months ago

betzster - Not per site. If I go to any site, I can only see the themes active for the network or that site.

A separate section 'The following these are not enabled for this site...' with an 'Enable and Activate' sort of button would be nice. Hide it so only the super admin can see it.

comment:22 jeremyfelt3 months ago

  • Component changed from Network Admin to Themes
  • Focuses ui added
Note: See TracTickets for help on using tickets.