WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#18304 closed enhancement (fixed)

Don't cut 'Network Admin' from long network name

Reported by: johnbillion Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.2.1
Component: Network Admin Keywords: has-patch
Focuses: multisite Cc:

Description

If a site or network name is longer than 30 characters it gets snipped and appended with an ellipsis.

On network admin screens, the appended 'Network Admin' gets snipped if the network title is too long. We should append 'Network Admin' after the snip to prevent this.

Attachments (3)

18304.patch (1.5 KB) - added by johnbillion 10 years ago.
18304.2.patch (2.1 KB) - added by johnbillion 10 years ago.
18304.3.diff (710 bytes) - added by duck_ 10 years ago.

Download all attachments as: .zip

Change History (11)

@johnbillion
10 years ago

#1 @johnbillion
10 years ago

  • Keywords has-patch added

Patch which turns this:

Really Really Really Long Network Name N...

into the preferred:

Really Really Really Long Netw... Network Admin

#2 @nacin
10 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to nacin
  • Status changed from new to accepted

#3 @westi
10 years ago

The magic numbers (30 and 40) here look suspicious.

I'm not sure this solution is i18n safe if the translation is longer/shorter.

#4 @johnbillion
10 years ago

Second pass at a patch. Uses string length of localised strings to calculate the maximum title length.

#5 follow-ups: @jane
10 years ago

  • Type changed from defect (bug) to enhancement

What if we flipped it, so it was

Network Admin: Really Really Really Long Network Name

That should address issues with i18n and would also create a better visual distinction between individual site dashboards and the network admin.

#6 in reply to: ↑ 5 @SergeyBiryukov
10 years ago

Replying to jane:

What if we flipped it, so it was
Network Admin: Really Really Really Long Network Name

+1, that's what I ended up doing in the localized version for the same reasons. Though it actually looks like this:

Управление сетью: Really Really Really Lo...

Is there a reason not to increase that 40-character limit for Network Admin?

@duck_
10 years ago

#7 in reply to: ↑ 5 @duck_
10 years ago

Replying to jane:

What if we flipped it

That makes a lot of sense. Patch attached.

#8 @westi
10 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18675]:

Reorder the titles in the Network Admin and Global Dashboard to put the locations first. Fixes #18304 props duck_

Note: See TracTickets for help on using tickets.