WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #18311, comment 41


Ignore:
Timestamp:
02/17/2012 08:19:40 PM (13 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18311, comment 41

    initial v1  
    22> We're screwed there either way... So, we need to figure out how to be compatible here.
    33
    4 Not exactly. The current patch is backwards compatible. All it does is to force the quotes in the newly added HTML inside captions to be single. This works well and doesn't require any changes to the shortcode format or the handling/parsing of the shortcode in the back-end, including plugins. Furthermore is accepts both quotes formats when editing a post, so even if a plugin has added a caption shortcode using single quotes for the attributes (default is to use double quotes), it would handle it properly.
     4Not exactly. The current patch is backwards compatible. All it does is to force the quotes in the newly added HTML inside captions to be single. This works well and doesn't require any changes to the shortcode format or the handling/parsing of the shortcode in the back-end, including plugins.
     5
     6Furthermore it accepts both quote formats when editing a post, so even if a plugin has added a caption shortcode using single quotes for the attributes (default is to use double quotes), it would handle it properly.
    57
    68Agree with @sushkov that now would be a good time to tweak/improve the captions shortcode but don't see any way we can do that and keep it 100% backwards compatible.