Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#18333 closed enhancement (fixed)

Deprecate get_userdatabylogin() and get_user_by_email()

Reported by: scribu Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch
Focuses: Cc:


They have ugly names and are just wrappers for get_user_by().

We should at least not use them in Core anymore.

Attachments (3)

18333.diff (6.1 KB) - added by scribu 4 years ago.
18333.2.diff (6.8 KB) - added by scribu 4 years ago.
18333.3.diff (638 bytes) - added by scribu 4 years ago.

Download all attachments as: .zip

Change History (11)

@scribu4 years ago

comment:1 @scribu4 years ago

  • Keywords has-patch added

comment:2 @SergeyBiryukov4 years ago

While adding them to pluggable-deprecated.php, the patch doesn't remove them from pluggable.php. Is that intended?

@scribu4 years ago

comment:3 @scribu4 years ago

Nope; good catch.

comment:4 @ryan4 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [18513]:

Deprecate get_userdatabylogin() and get_user_by_email(). Props scribu. fixes #18333

comment:5 @ryan4 years ago

  • Milestone changed from Awaiting Review to 3.3

comment:6 @ocean904 years ago

Typo in inline docs?

@deprecated 2.5 should be @deprecated 3.3.0.

@scribu4 years ago

comment:7 @scribu4 years ago

Indeed. See 18333.3.diff.

By the way, in [18513] the svn:mergeinfo property was changed for some reason.

comment:8 @ryan4 years ago

In [18514]:

Update @deprecated. Props scribu. see #18333

Note: See TracTickets for help on using tickets.