#18340 closed defect (bug) (fixed)
Quickedit on Spam Comments adds approve and unapprove
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.3 | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
repro:
Get a spam
click on quick edit
hit update comment
see attached screenshot
(top: normal look - bottom: after updating comment)
Not sure if that is by design, but it looks a little bit strange
Attachments (4)
Change History (21)
#1
@
14 years ago
- Keywords needs-patch added; dev-feedback removed
- Milestone changed from Awaiting Review to 3.3
#2
@
14 years ago
The problem is, that $comment_status
is NULL, which is needed for this if clause.
In admin-ajax.php line 730 $comment_status
will be defined but it isn't global.
#4
@
14 years ago
Perhaps the bug is having Quick Edit on spam. This makes no sense :) If a comment is not spam you should mark it as such before editing. If it is... why would you edit it?
#5
follow-up:
↓ 6
@
14 years ago
i use antispam bee (AB) and one of its features is adding a notice why it was added to spam. Like "[MARKED AS SPAM BY ANTISPAM BEE | CSS Hack]"
Another option is, that AB marks all non-german or non-english comments als spam. for that it uses google translate and sometimes it is wrong.
so i remove the notice with quick edit
#6
in reply to:
↑ 5
@
14 years ago
Replying to hebbet:
Then your workflow for false positives (ham marked as spam) should be:
- Unspam.
- Edit the comment.
#7
follow-up:
↓ 8
@
14 years ago
I don't think that the bug is to have Quick Edit on spam comments, it's also available for unapproved comments.
The bug exists since the new list table API.
#8
in reply to:
↑ 7
@
14 years ago
Replying to ocean90:
IMHO spam comments are very similar to trashed comments. The only difference is that they were trashed automatically by a plugin or by matching a word, number of URLs, etc.
Unapproved comments are "undecided". That's why we have Edit and Approve as a combined editing action for them. This happens often in the workflow.
We should either extend the Edit and Approve to spam comments or completely remove editing there.
#9
@
14 years ago
IMO spam comments are very similar to unapproved comments. There aren't trashed, they only get as status spam. So I know it from most of the plugins. I must decide if it's really a spam comment or not.
If they are trashed automatically then no Quick Edit is possible, that's fine.
+1 for Edit and Approve ( or Unspam)
#10
@
14 years ago
I would be down for removing Quick Edit from Spam. Making a clear distinction between spam and trash or not-yet-approved helps less savvy users. And if it's something that is to be edited, then it can be marked Not Spam and still left in moderation or put in trash.
#11
@
14 years ago
- Cc mike.schroder@… added
Attached patch removes Edit+Quick Edit from posts in Spam
#13
@
14 years ago
Updated patch to reflect duck_'s suggestions in IRC.
The added error message in wp-admin/comment.php could use a check/suggestions, since I was unsure how to phrase marking a comment as "not spam", while still keeping the same basic structure as the error for editing Trash'd messages.
Confirmed.
No, it makes no sense.