Don't compute in_search_post_types if we're not going to use it

[mitchoyoshitaka]

In WP_Query::get_posts(), we call get_post_types( array('exclude_from_search' => false) ) which we store as $in_search_post_types, but we only actually use it if ( 'any' == $post_type ). The result is not used anywhere else. We should move this into the conditional.

[mitchoyoshitaka]

Wait, just noticed that this logic here might in fact have a flaw: if there are no post types which have exclude_from_search = false, then magically *all* post types will be checked? Am I reading this right? In that case, shouldn't we just immediately return no results?

Obviously, this wouldn't be an issue except in a very customized setup where all post types have exclude_from_search = true, but still... thoughts anyone?

[ryan]

In [19078]:

Compute in_search_post_types only when needed. Props mitchoyoshitaka. fixes #18364

[nacin]

mitcho, your comment sounds like it is worthy of a new ticket.

[mitchoyoshitaka]

Replying to nacin:

mitcho, your comment sounds like it is worthy of a new ticket.

#19198 opened.

[kawauso]

$exclude_post_types is now unused.

[nacin]

In [19216]:

Remove unused variable. props kawauso, see #18364.