WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#18374 closed defect (bug) (invalid)

Twenty Eleven: don't underline unclickable nav menu items

Reported by: mitchoyoshitaka Owned by:
Milestone: Priority: normal
Severity: trivial Version: 3.2
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Right now in Twenty Eleven both clickable and unclickable nav menu items get underlined. The cursor does change between them (well, this may depend on the browser, but...) but otherwise it's not immediately obvious that some items are not clickable.

Here's a patch which fixes this which uses attribute selectors, and thus should work with most modern browsers but crucially not IE6.

Attachments (1)

18374.diff (569 bytes) - added by mitchoyoshitaka 4 years ago.

Download all attachments as: .zip

Change History (4)

@mitchoyoshitaka4 years ago

comment:1 follow-up: @johnbillion4 years ago

Which nav menu items are unclickable?

comment:2 in reply to: ↑ 1 @mitchoyoshitaka4 years ago

Replying to johnbillion:

Which nav menu items are unclickable?

You can create nav menu items which don't actually have an href, for example as the top level item for a submenu. You can do it in the menu manager by creating a custom link, then clearing out the URL field.

An example is at http://arts.mit.edu : in the top nav, some items show submenus and are not really clickable, while other top-level items are actually clickable. This site currently has the kid of styling I'm advocating for here, where actually meaningfully-clickable items get underlining (and the cursor turning into the pointer, but that's the browser's doing), but those which have no href get none.

comment:3 @lancewillett3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing as invalid since navigation menu links in Twenty Eleven do not have text-decoration: underline; by default, so unless you change that the navigation menus won't have underlines.

See http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyeleven/style.css#L566

Note: See TracTickets for help on using tickets.