WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#18394 closed defect (bug) (fixed)

wp-admin/install.php doesn't respect SCRIPT_DEBUG being set to true

Reported by: jorbin Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

It never loads the .dev.js javascript files even if SCRIPT_DEBUG is set to true

Attachments (1)

18394.diff (1.1 KB) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.3

See my comment at 11520#comment:52 for a few related notes.

This bug is because install.php is trying to reference scripts directly even when it doesn't need to. Not sure how it hasn't been caught until now, and not sure if there is another place in core where we should be making a similar change.

Patch attached.

@nacin4 years ago

comment:2 @nacin4 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18544]:

Use wp_print_scripts() in install.php. Fixes issues with SCRIPT_DEBUG, removes l10n.js reference. fixes #18394.

Note: See TracTickets for help on using tickets.