Make WordPress Core

Opened 18 years ago

Closed 18 years ago

Last modified 17 years ago

#1840 closed defect (bug) (fixed)

Going back to normal ?p=X permalink structure is confusing

Reported by: markjaquith's profile markjaquith Owned by: markjaquith's profile markjaquith
Milestone: Priority: normal
Severity: normal Version: 1.6
Component: Administration Keywords: bg|has-patch bg|squashed bg|commit
Focuses: Cc:


The normal ?p=X permalink structure should be a preset. as it is, you have to select "custom" and make it blank.

I'm working on a patch.

Attachments (1)

options-permalink.php.diff (2.8 KB) - added by markjaquith 18 years ago.
patch for WP 1.6 SVN

Download all attachments as: .zip

Change History (5)

#1 @markjaquith
18 years ago

  • Keywords bg|has-patch bg|squashed bg|commit added
  • Status changed from new to assigned

Okay, my patch ended up fixing more than just that.

  • added ?p=123 as "Default"
  • cleaned up repetitive text by storing the rewrite structures in an array
  • Added two more methods of finding out if the server doesn't support mod_rewrite. First, it checks for a non-apache server, like before. Next, if tries looking for mod_rewrite in the apache_get_modules() function (protected by function_exists() ). Next, it buffers phpinfo(INFO_MODULES) and looks for the presence of 'mod_rewrite' (with function_exists() protection on ob_get_clean() )

I also made it easier to read, with the example URI structure on the next line

18 years ago

patch for WP 1.6 SVN

#2 @ryan
18 years ago

save_mod_rewrite_rules() needs the same mod_rewrite checks. Maybe put all of that in got_mod_rewrite()?

#3 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3029]) Add radio button for our default permalink structure. Add got_mod_rewrite(). Props Mark Jaquith. fixes #1840

#4 @(none)
17 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.