wp_insert_category() is Not Properly Abstracted

[miqrogroove]

If you look in ​http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/taxonomy.php there is still a note that says "The 'taxonomy' key was added in 3.0.0."

However, this function calls category_exists() and cat_is_ancestor_of(), which never recognized the taxonomy argument.

[miqrogroove]

Perhaps more to the point, in edit-tags.php function wp_insert_term() is called rather than wp_insert_category(). It may have been the original intention to deprecate wp_insert_category() in favor of the proper logic. Is this function still being used in core?

[nacin]

It gets used in a few spots, but I imagine it should be consolidated into wp_insert_term().

[Dvvarf]

Replaces wp_insert_category with wp_insert_term/wp_update_term accordingly

[Dvvarf]

The patch replaces all calls to wp_insert_category with calls to corresponding term functions. wp_insert_category, however, had $wp_error argument, that was used to suppress returning WP_Error, so I added it to wp_insert_term and wp_update_term functions. Any opinions on this approach?
P.S. First patch. =)

[wonderboymusic]

The patch has a lot of bizarre whitespace - please refresh with the WP Coding Standards in mind

[wonderboymusic]

We do some replacing of the *_category() functions to use *_term() functions in the past couple of releases - needs to be refreshed and reviewed