WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 4 weeks ago

#18449 new defect (bug)

List Table Factory Needs to be Pluggable

Reported by: miqrogroove Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Better design planning should have been considered for http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/list-table.php

function _get_list_table() is identical to an object factory pattern, which would make more sense as a static member of WP_List_Table. In other words...

$wp_list_table = _get_list_table('WP_Terms_List_Table');

... which looks simple, is actually confusing because it would be more intuitive if written as ...

$wp_list_table = WP_List_Table::factory('Terms');

Further, the factory hasn't offered any extensibility. Locking edit-tags.php against WP_Terms_List_Table makes it unusable for custom taxonomies that need a custom UI. Despite all of the great API improvements for taxonomies, this case still necessitates duplicating the entire category editing UI within a plugin just to tweak a table column or a link path.

Please adjust the ticket Type and Component as necessary. It could be a taxonomy design flaw or an administration enhancement, depending how you look at it.

Attachments (1)

18449.diff (1.0 KB) - added by Faison 4 weeks ago.
Adding a filter to _get_list_table() to allow developers to return an object of their own class in place of core classes

Download all attachments as: .zip

Change History (11)

comment:1 @nacin4 years ago

_get_list_table() used to be get_list_table(), and it had a filter to allow for switching out tables.

When we pulled out XHR bits and made the entire API private near the end of 3.1, we renamed it to the current, private version.

When someone finally takes ownership of and rewrites the list table API, I think this would indeed be a good approach.

comment:2 @scribu4 years ago

  • Milestone changed from Awaiting Review to Future Release

Somewhere in Space this may all be happening right now.

comment:4 @sirzooro4 years ago

  • Cc sirzooro added

comment:5 @kurtpayne4 years ago

  • Cc kpayne@… added

comment:6 @johnbillion3 years ago

  • Cc johnbillion added
  • Component changed from Taxonomy to Administration

comment:7 @SergeyBiryukov20 months ago

#24938 was marked as a duplicate.

comment:9 @jrbeilke15 months ago

  • Cc jrbeilke@… added

@Faison4 weeks ago

Adding a filter to _get_list_table() to allow developers to return an object of their own class in place of core classes

comment:10 @Faison4 weeks ago

  • Keywords has-patch added

I recently ran into a situation where I needed to make some extensive customizations to the WP_Media_List_Table class and the filters it provided was not enough. So I'm hoping I can bring life back to this ticket with a patch that would help us all out.

It adds the filter 'pre_get_list_table' to _get_list_table(). It allows a developer to check what class was requested, and return an object of a different class if needed.

Note: See TracTickets for help on using tickets.