![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 15 years ago
Closed 15 years ago
#18463 closed defect (bug) (fixed)
wp_mail() does not allow"<address@tld.com>", regression
| Reported by: | kitchin | Owned by: | westi |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.3 |
| Component: | Version: | 3.2.1 | |
| Severity: | normal | Keywords: | has-patch westi-likes |
| Cc: | Focuses: |
Description
This regression was caused by Ticket #17305: wp_mail() does not accommodate address format "Name <address@…>".
The format "<address@…>" no longer works, it has to be "address@…". In Ticket #17305 Comment 12 commenter Pavelevap says this is a regression.
I explained already in Ticket #17305 Comment 11 why the new regex is not optimal (greediness), and I provided a new regex:
patch was: '/(.+)\s?<(.+)>/'
should be: '/(.*)<(.+)>/'
I called it an enhancement, because the new regex would make "<address@…>" work without a "Name" in front. But it seems actually to fix a regression.
For belt-and-suspenders, trim() can be applied to the results, as it is now, though the call to AddAnAddress() actually does the trim() anyway.
Attachments (1)
Change History (10)
#3
follow-up:
↓ 7
@
15 years ago
- Keywords westi-likes added
- Milestone Awaiting Review → 3.3
- Owner set to
- Status new → accepted
We need to add some test cases for this here too - http://unit-tests.trac.wordpress.org/browser/wp-testcase/test_includes_pluggable.php#L144
Thank you for creating this ticket...