Search with blank criteria returns results in wrong template file.

[baderatw]

If you use the search but leave the criteria field blank, the results are returned in the standard template instead of search.php

[dd32]

Just to confirm, You're refering to something such as: http://example.com/?s= ?

WordPress treats empty query vars as if they don't exist, therefor, in that situation it'd most likely load the blog index.

[baderatw]

Yes, that's exactly what I mean. Rather inconvenient because it's probable that a user could click search with no criteria...

[baderatw]

Thank you for the quick response!

[dd32]

Tickets are closed when a commit is made to the WordPress trunk to fix the issue, not when a patch is posted

[baderatw]

Yeah, that fix didn't work anyway. I thought it did... but when I looked back at the root of the site, every page is showing up as search results template now.

[SergeyBiryukov]

Yep, scratch that. I should have tested more thoroughly.

[baderatw]

Is there somewhere else in the code that the $qvs? variable is checked in regards to templates?

[baderatw]

Got it. Your patch along with this:

query.php line 1387

/*, 's'*/

[SergeyBiryukov]

WordPress prefills all query vars (including s) with empty values, so that's probably by design.

A workaround might look like this:

function load_search_template_for_blank_criteria() {
	global $wp_query;
	if ( isset( $_GET['s'] ) )
		$wp_query->is_search = true;
}
add_action('template_redirect', 'load_search_template_for_blank_criteria');

[baderatw]

Ok - I un-commented 1387 and changed 1470 to

if (isset($_GET['s'])) {

This works too.

[ocean90]

This works too.

Oh no! ​http://codex.wordpress.org/images/b/b3/donthack.jpg

[SergeyBiryukov]

#10156