Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#18487 closed defect (bug) (fixed)

Unable to bookmark "Press This" in Internet Explorer 8

Reported by: evarlese Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Press This Keywords: has-patch
Focuses: Cc:


In using the most current version of WordPress.org in Internet Explorer 8, users are unable to boomark the "Press This" tool available under Dashboard > Settings > Writing.

To replicate:

  1. Visit your Dashboard > Settings > Writing in Internet Explorer 8 (or 9).
  1. Place your mouse over the "Press This" button and attempt to right click and Save to your Bookmarks. The right-click will not function.
  1. As an alternative, try dragging the "Press This" button to your bookmarks. The button will not drag.

Because Internet Explorer does not allow users to manually add Bookmarks, it is impossible to copy and paste the "Press This" URL into your Bookmarks. Additionally, users cannot copy and paste the Javascript into their Bookmarks: http://en.forums.wordpress.com/topic/1st-question-downloading-a-photo-to-my-sidebar?replies=11#post-664096

This is a problem for WordPress.com users as well.

Attachments (2)

18487.patch (1.6 KB) - added by dllh 4 years ago.
Adds context click instructions for MSIE user agents
18487.2.patch (3.3 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (8)

#1 @nacin
4 years ago

  • Milestone changed from Awaiting Review to 3.2.2

4 years ago

Adds context click instructions for MSIE user agents

#2 @dllh
4 years ago

  • Cc daryl@… added
  • Keywords has-patch added

It appears that IE8 doesn't support draggable bookmarklets. I found a few bits online suggesting as much, and testing with a very simple bookmarklet (to rule out the possibility of something within this particular bookmarklet being a problem) supports this diagnosis.

A workaround might be to do for MSIE what we do for Webkit browsers -- showing on context click the bookmarklet script and some instructions for pasting into a new bookmark in the bookmark manager. The attached patch adds such a workaround very broadly (any MSIE user agent, which for the time being is probably ok given that bookmarklet dragging is also hosed in IE9).

Improvements would include version-specific display and perhaps more specific instructions per browser. I'll hold off on such implementations pending ratification of the general approach, though (maybe my proposed workaround is dumb).

#3 @duck_
4 years ago

  • Milestone changed from 3.2.2 to 3.3

Patch looks good.

Original ticket says "Internet Explorer does not allow users to manually add Bookmarks", true or false? Patch suggests otherwise.

#4 follow-up: @azaozz
4 years ago

Don't see a problem with dragging the bookmarklet to the "Favorites" bar in IE. As far as I remember it was never possible to add the bookmarklet by dragging it to anywhere else. Still the workaround for webkit can be shown for IE too.

#5 in reply to: ↑ 4 @SergeyBiryukov
4 years ago

Replying to azaozz:

Don't see a problem with dragging the bookmarklet to the "Favorites" bar in IE.

Dragging is possible in IE 9, but not in IE 8, which doesn't seem to have any option to manually add a bookmark like that.

Not sure if the patch makes any sense therefore, but if it does, the same change also needs to happen in options-writing.php.

#6 @azaozz
4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19387]:

Extend the workaround for adding the Press This bookmarklet to IE, props dllh SergeyBiryukov, fixes #18487

Note: See TracTickets for help on using tickets.