Calling wp_get_attachment_link with a non-existent ID throws PHP notice

[Jayjdk]

If you're are using the wp_get_attachment_link() function with a non-existent attachment ID, you'll get a notice.

Example:
<?php echo wp_get_attachment_link( 9 ); ?>

gives Notice: Trying to get property of non-object in C:\wamp\www\theme\wp-includes\post-template.php on line 1155

As far I can see, the code causing it is this (wp-includes\post-template.php on line 1155)

$_post = & get_post( $id );

if ( ('attachment' != $_post->post_type) || !$url = wp_get_attachment_url($_post->ID) )
	return __('Missing Attachment');

The $_post variable will be null in this case.

[Jayjdk]

Nice! Just to confirm; the patch from Sergey fixes the error

[Jayjdk]

Updated the function to follow the WordPress Coding Standards

[ethitter]

Tested 18491_2.patch​ and it works for me.

[ryan]

In [19210]:

Avoid warning when non-existent ID pass to wp_get_attachment_link(). Tidy formatting of wp_get_attachment_link(). Props SergeyBiryukov, Jayjdk. fixes #18491

[nacin]

In [19212]:

Simplify logic in wp_get_attachment_link(). see #18491.