suggest.js: don't store the URL in the options object

[scribu]

...because it prevents re-using the same instance for different URLs:

var suggest_args = {
	multiple     : true,
	delimiter    : ',',
	resultsClass : 'qc-suggest-results',
	selectClass  : 'qc-suggest-over',
	matchClass   : 'qc-suggest-match',
};

$( '#ticket-assign input' ).suggest( QC_L10N.ajaxurl + '?action=qc-user-search', suggest_args );

$( '#ticket-tags input' ).suggest( QC_L10N.ajaxurl + '?action=ajax-tag-search&tax=post_tag', suggest_args );

With the above code, both inputs will look for items in the same URL: the second one.

Attached patch fixes this.

[GaryJ]

Will that extra argument be backwards compatible?

Could you add some code such that if source is an object rather than a string (i.e. only two arguments passed in), that source = options.source?

[scribu]

That extra argument only affects the internal constructor function, which shouldn't be used directly.

If it's really necessary, sure, you could check if it's an object vs. a string or check the number of arguments passed.

[chriscct7]

Needs to be refreshed

[DrewAPicture]

@markjaquith: Could you please take a look at this and give it a yea or nay? It's been out there for four years, not sure if it's still worth pursuing.

[obenland]

suggest.js is unused in Core as of [38797].