Opened 13 years ago
Closed 13 years ago
#18544 closed enhancement (fixed)
Remove wp-register.php
Reported by: | christopherross | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.4 | Priority: | normal |
Severity: | trivial | Version: | 3.3 |
Component: | General | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
added spacing to wp-register.php to match Codex Coding Standards for brackets
Attachments (3)
Change History (17)
#3
@
13 years ago
- Milestone changed from Awaiting Review to 3.3
- Summary changed from Spacing fixed in WP-Register.php to Remove wp-register.php
Actually, I think we could probably remove wp-register.php the way we removed the feed files.
#4
@
13 years ago
18544.patch removes wp-register.php
and performs canonical redirect to the appropriate place.
Needs bumping the db version on commit to regenerate rewrite rules.
#5
@
13 years ago
Should we add it to $_old_files
to be removed on upgrade? We didn't do that for the feed files to prevent possible breakage in case of a lame use.
#9
@
13 years ago
Can't get this to work. Not sure what happened, but the redirect isn't working for the feed files either.
#10
@
13 years ago
The redirect from wp-register.php
to wp-login.php?action=register
seems to work fine on my install (after applying the patch and flushing rewrite rules, which, according to admin.php
, happens on DB upgrade). The redirect for the feed files works as well.
Refreshed the patch.
#11
follow-up:
↓ 12
@
13 years ago
@SergeyBiryukov / @Nacin would it be possible to remove the wp-pass.php file using the same approach? Chris
if ( 'wp-pass.php' == basename( $redirect['path'] ) ) { // 10 days setcookie('wp-postpass_' . COOKIEHASH, stripslashes( $_POST['post_password'] ), time() + 864000, COOKIEPATH); wp_safe_redirect(wp_get_referer()); die(); }
http://wpdevel.wordpress.com/2011/03/23/code-refactoring/
There was a number of code cleanup tickets like #17997, and the consensus was that coding style fixes should be a result of more substantial changes than just improving readability.