WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 9 months ago

#18556 accepted defect (bug)

Toolbar dropdowns when dragging items

Reported by: chexee Owned by: drecodeam
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.2.1
Component: Toolbar Keywords: needs-patch
Focuses: ui Cc:

Description (last modified by nacin)

When dragging metaboxes, widgets, menu items, etc to the top of the window in order to scroll to drop the item on a portion of the UI that's above the viewing window, the toolbar interferes and produces dropdowns, etc.

If dragging an item, can we disable toolbar actions?

Attachments (3)

menu-adminbar-drop.png (101.6 KB) - added by chexee 3 years ago.
18556.diff (1.7 KB) - added by drecodeam 2 years ago.
resolved issue by binding empty functions on 'start' method of jquery sortable function and then binding original functions on 'stop' method.
18556.2.diff (2.8 KB) - added by jessepollak 9 months ago.

Download all attachments as: .zip

Change History (14)

comment:1 ocean903 years ago

Screenshot?

chexee3 years ago

comment:2 chexee3 years ago

Attached. Sorry, had to open grab and do a timed screenshot. Kept dropping the menu item when I used shortcuts.

comment:3 DrewAPicture2 years ago

  • Type changed from defect (bug) to enhancement
  • Version set to 3.2.1

comment:4 nacin2 years ago

  • Component changed from General to UI
  • Type changed from enhancement to defect (bug)

Sounds like a bug, but I can reproduce this in 3.2 as well.

I imagine this should be easy to do?

drecodeam2 years ago

resolved issue by binding empty functions on 'start' method of jquery sortable function and then binding original functions on 'stop' method.

comment:5 drecodeam2 years ago

  • Cc drecodeam added
  • Keywords has-patch reporter-feedback added

comment:6 drecodeam2 years ago

  • Owner set to drecodeam
  • Status changed from new to accepted

comment:7 nacin2 years ago

  • Description modified (diff)
  • Summary changed from Admin menu dropdowns when dragging items to Toolbar dropdowns when dragging items

Updating "admin menu" to "toolbar" since "admin menu" refers to the left menu.

comment:8 DrewAPicture15 months ago

  • Component changed from UI to Toolbar

comment:9 helen15 months ago

  • Keywords ui-focus added; reporter-feedback removed

comment:10 enej9 months ago

  • Keywords needs-patch added; has-patch removed

This tickets needs a new patch. The current patch only changes the post meta boxes, also the file against witch the patch was applied to doesn't exist any more.

The bug currently effects all the different places we have the drag and drop feature.
(menus, widgets and post-meta boxes but not galleries)

Since its a minor bug I would suggest fixing it once MP6 is released.

jessepollak9 months ago

comment:11 jessepollak9 months ago

Definitely not the most elegant solution, but I figured I would take a stab and then work from there with people's feedback. This fixes the problem for widgets, post-meta boxes and menus; I'm pretty sure those are the only places it was an issue.

In a more ideal patch, we'd only add the draggable.start and draggable.stop triggers once, rather than every time we make something draggable. The current solution would leave room to reintroduce this bug the next time we add a draggable element.

Note: See TracTickets for help on using tickets.