WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#18566 closed enhancement (fixed)

Expose discussion settings on XML-RPC

Reported by: daniloercoli Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: XML-RPC Keywords: mobile has-patch commit
Focuses: Cc:

Description

To set properly the mobile UI we should be able to access the discussion settings variables from XML-RPC.

  • default_ping_status
  • default_comment_status

Attachments (1)

18566.diff (770 bytes) - added by daniloercoli 3 years ago.

Download all attachments as: .zip

Change History (6)

daniloercoli3 years ago

comment:1 daniloercoli3 years ago

  • Keywords has-patch added; needs-patch removed

comment:2 kurtpayne2 years ago

  • Cc kpayne@… added
  • Type changed from defect (bug) to enhancement

comment:3 josephscott2 years ago

  • Cc josephscott added
  • Keywords commit added

I'm ok with this idea and patch, with one reservation. The two options default_ping_status & default_comment_status expect string values, specifically: 'open' & 'closed'. Anything other than those two values, from what I've seen so far, will result in it being treated as closed.

Besides that one concern I'm fine with having this patch committed.

comment:4 SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.4

comment:5 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19706]:

Expose default_ping_status and default_comment_status via XML-RPC. props daniloercoli. fixes #18566.

Note: See TracTickets for help on using tickets.