WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#18568 closed defect (bug) (fixed)

Post title field should be hidden in DFW if not listed in "supports" in post type registration.

Reported by: jtsternberg Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: General Keywords: has-patch
Focuses: Cc:

Description

As it is, if you create a custom post type, and don't list "title" in the "supports" list, then you won't have a title field in the normal editor (as it should be), but when you click the full screen editor, the title field is displayed. This goes for the editor textarea as well.

The diff file adds the post_type_supports check that the default editor.

Attachments (2)

18568.diff (1.3 KB) - added by jtsternberg 3 years ago.
18568.2.diff (1.0 KB) - added by jtsternberg 3 years ago.

Download all attachments as: .zip

Change History (8)

jtsternberg3 years ago

comment:1 jtsternberg3 years ago

I stand corrected... if the editor areas is not listed in "supports" than the full screen button isn't even available, but the patch addresses the title issue.

comment:2 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.3

It would be better to remove the fields all together rather than via CSS.

jtsternberg3 years ago

comment:3 jtsternberg3 years ago

I agree, but the new attached diff is the best I can do. wp-fullscreen.dev.js requires the #wp-fullscreen-title id (see line 306 of wp-fullscreen.dev.js) or the full-screen button will not initiate full-screen mode. I am not a js wizard, so if there's a better way, please enlighten me.

comment:4 nacin3 years ago

  • Owner changed from jtsternberg to azaozz
  • Status changed from new to assigned

comment:5 azaozz3 years ago

  • Component changed from UI to General
  • Summary changed from Full Screen Editor Fields should be hidden if not listed in "supports" in post type registration. to Post title field should be hidden in DFW if not listed in "supports" in post type registration.

comment:6 azaozz3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [18828]

Note: See TracTickets for help on using tickets.