WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18582 closed defect (bug) (fixed)

Remove unneeded siblings('.widget-holder') from widgets.js

Reported by: aaroncampbell Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 2.9
Component: Widgets Keywords: has-patch
Focuses: Cc:

Description

Currently we do this:
$(this).siblings('.widget-holder').parent().toggleClass('closed');
However, since the parent() of the current element is the same as the parent of it's siblings I don't think we need to move to a sibling at all.

Attachments (1)

18582.diff​ (509 bytes) - added by aaroncampbell 3 years ago.

Download all attachments as: .zip

Change History (3)

aaroncampbell — 3 years ago

comment:1 azaozz — 3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18634]:

Remove unneeded .siblings() from widgets.js, props aaroncampbell, fixes #18582

comment:2 ocean90 — 3 years ago

  • Milestone changed from Awaiting Review to 3.3
Note: See TracTickets for help on using tickets.