WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#18585 closed enhancement (fixed)

Make twentyeleven_content_nav pluggable

Reported by: adeptris Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: minor Version: 3.2.1
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

This is just for a theme function future release consideration.

I was looking at a question in the forum, it was in relation to one of the pagination plugins.

Using a child theme, I was going to suggest creating the twentyeleven_content_nav function with conditional wp-pagenavi or wp-pagination code, with just a couple of code lines.

With the Twenty Eleven functions.php the function twentyeleven_content_nav, we cannot override the function in a child theme, so we have to copy across index.php etc: to the child theme and edit the navigation code blocks

As I said just for future consideration to make the function conditional like many of the others in functions.php

Kind Regards

David

Attachments (1)

18585.patch (646 bytes) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
7 years ago

  • Component changed from Themes to Bundled Theme
  • Keywords has-patch added

#2 follow-up: @adeptris
7 years ago

Cheers Sergey, New here, should I have proposed the patch when I posted, I was just pointing it out as a suggestion for a future release.

Regards

David

#3 @scribu
7 years ago

  • Summary changed from Function exists code twentyeleven_content_nav to Make twentyeleven_content_nav pluggable

#4 in reply to: ↑ 2 @SergeyBiryukov
7 years ago

Replying to adeptris:

New here, should I have proposed the patch when I posted, I was just pointing it out as a suggestion for a future release.

It's just that tickets with patches generally have a chance to be reviewed (and possibly committed) sooner.

#5 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 3.3

#6 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19242]:

Make twentyeleven_content_nav() pluggable. props adeptris, SergeyBiryukov. fixes #18585.

Note: See TracTickets for help on using tickets.