WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#18591 closed enhancement (fixed)

mytheme-child does not work when installing a new blog

Reported by: minimarket Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Themes Keywords: has-patch commit
Focuses: Cc:

Description

If I choose own theme when installing a blog

define ('WP_DEFAULT_THEME', 'mytheme');

then it works, but if I choose child theme

define ('WP_DEFAULT_THEME', 'mytheme-child');

then I must go to Appearance -> Themes to choose it manually. She was not taken up automatically.

Attachments (2)

18591.patch (841 bytes) - added by SergeyBiryukov 3 years ago.
18591.2.patch (849 bytes) - added by SergeyBiryukov 3 years ago.
Added cast to array

Download all attachments as: .zip

Change History (12)

comment:1 minimarket3 years ago

  • Keywords needs-patch added
  • Type changed from defect (bug) to enhancement

comment:2 dd323 years ago

Source reference for those interested: populate_options()

Depending on the state of the loading at that point in time, we could query for the theme through get_themes() and extract the template from there, Alternatively, we could add a new define for the Template if we're unable to query at that point in time.

SergeyBiryukov3 years ago

comment:3 follow-up: SergeyBiryukov3 years ago

  • Keywords has-patch added; needs-patch removed

get_themes() works fine there.

comment:4 in reply to: ↑ 3 minimarket3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Replying to SergeyBiryukov:

get_themes() works fine there.

Thank you! The patch is really working fine.

comment:5 follow-up: dd323 years ago

  • Component changed from General to Themes
  • Resolution fixed deleted
  • Status changed from closed to reopened

Tickets are marked as fixed when a change is made to the WordPress codebase, the patch here still needs to be committed before the ticket will be marked as such.

comment:6 in reply to: ↑ 5 minimarket3 years ago

Replying to dd32:

Tickets are marked as fixed when a change is made to the WordPress codebase, the patch here still needs to be committed before the ticket will be marked as such.

Oops.. Sorry, This is my first ticket...

SergeyBiryukov3 years ago

Added cast to array

comment:7 SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.3

Moving to 3.3 for consideration.

comment:8 DrewAPicture2 years ago

Tested 18591.2.patch on trunk, works as advertised.

Last edited 2 years ago by DrewAPicture (previous) (diff)

comment:9 nacin2 years ago

  • Keywords commit added

comment:10 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from reopened to closed

In [19249]:

Properly handle child themes for WP_DEFAULT_THEME. Props SergeyBiryukov. fixes #18591

Note: See TracTickets for help on using tickets.