add trailingslashit to BLOGUPLOADDIR in ms-files.php

[wonderboymusic]

BLOGUPLOADDIR is trailingslashit'd inconsistently - since this value can be set by the user, adding trailingslashit to the constant value in ms-files.php will prevent broken images in sub-blogs when in Multisite mode

// WRONG
define( 'BLOGUPLOADDIR', $_SERVER['DOCUMENT_ROOT'] . "/blogs.dir/{$the_id}/files" );

// RIGHT
define( 'BLOGUPLOADDIR', $_SERVER['DOCUMENT_ROOT'] . "/blogs.dir/{$the_id}/files/" );

// CURRENT 
$file = BLOGUPLOADDIR . str_replace( '..', '', $_GET[ 'file' ] );

// PROPOSED
$file = trailingslashit( BLOGUPLOADDIR ) . str_replace( '..', '', $_GET[ 'file' ] );

It's subtle, and hard to debug

[wonderboymusic]

Patch for this ticket

[nacin]

In [18637]:

Use untrailingslashit in url_shorten() and recurse_dirsize(). Remove unnecessary camelCase variables. see #18592.

[nacin]

Noticed a few other things while looking at BLOGUPLOADDIR usage. We rather consistently slash/unslash the constant depending on what we want to do with it -- except for here.

We should probably have unit tests for a lot of these constants.

[nacin]

In [18638]:

Force a trailing slash on BLOGUPLOADDIR in ms-files.php. props wonderboymusic, see #18592.

[davecpage]

This patch causes images in multisites not to display.

The issue is that the 'SHORTINIT' define at the top of wp-includes/ms-files.php causes wp-settings.php to not include wp-includes/formatting.php, which is where trailingslashit() exists.

[nacin]

In [18642]:

trailingslashit isn't normally available in ms-files. props davecpage, fixes #18592.