wp_get_shortlink() Should Always Return a URL

[cais]

Currently the code used in the link-template.php file causes the wp_get_shortcode function to return an empty result if the WordPress installation is using the default permalink structure. This causes at least issues with the_shortcode function and can be expected to cause issues any place that wp_get_shortcode is called when the default permalink structure is being used.

An alternative is to simply make the inline documentation state an empty result will be returned when the default permalink structure is used.

[chipbennett]

+1

Cais beat me to the punch!

[cais]

Replying to johnbillion: Good catch, I don't find many issues (and subsequent potential solutions) so I was a bit excited when I wrote up this ticket. Thanks.

[nacin]

To me it seems like the inline documentation should be updated.

Our shortlink API is designed to only provide a shortlink when one is available. If no shorter link is available, I'd rather not return something.

This patch would also be a change from its introduction. Not a backwards incompatible change, granted.

[ryan]

In 25030:

wp_get_shortlink() improvements.

• Return shortlinks for pages and public CPTs.
• Return shortlinks even when cruft-free links are not enabled.
• Unit tests

Props sillybean, layotte, cais
fixes #18632
see #14760