WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#18644 closed defect (bug) (fixed)

Media list table doesn't check for comment support

Reported by: johnbillion Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Media Keywords: has-patch
Focuses: Cc:

Description

If you remove support for comments from attachments*, the Comment column is still displayed on the Media screen. This is inconsistent with posts and pages, where the column gets removed.

*

remove_post_type_support( 'attachment', 'comments' );

Attachments (2)

18644.patch (881 bytes) - added by johnbillion 3 years ago.
18644.2.patch (897 bytes) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (8)

johnbillion3 years ago

comment:1 johnbillion3 years ago

  • Keywords has-patch added

Patch

comment:2 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to nacin
  • Status changed from new to accepted

comment:3 jane3 years ago

Yes, please fix this.

SergeyBiryukov3 years ago

comment:4 SergeyBiryukov3 years ago

18644.2.patch also fixes missing i18n in alt text.

comment:5 nacin3 years ago

This should be esc_attr__ in the future.

comment:6 nacin3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18931]:

Check post_type_supports before adding comments column to attachments. Translate a string. props johnbillion, SergeyBiryukov. fixes #18644.

Note: See TracTickets for help on using tickets.