WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#18644 closed defect (bug) (fixed)

Media list table doesn't check for comment support

Reported by: johnbillion's profile johnbillion Owned by: nacin's profile nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Media Keywords: has-patch
Focuses: Cc:

Description

If you remove support for comments from attachments*, the Comment column is still displayed on the Media screen. This is inconsistent with posts and pages, where the column gets removed.

*

remove_post_type_support( 'attachment', 'comments' );

Attachments (2)

18644.patch​ (881 bytes) - added by johnbillion 14 years ago.
18644.2.patch​ (897 bytes) - added by SergeyBiryukov 14 years ago.

Download all attachments as: .zip

Change History (8)

@johnbillion
14 years ago

#1 @johnbillion
14 years ago

  • Keywords has-patch added

Patch

#2 @nacin
14 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to nacin
  • Status changed from new to accepted

#3 @jane
14 years ago

Yes, please fix this.

@SergeyBiryukov
14 years ago

#4 @SergeyBiryukov
14 years ago

18644.2.patch​ also fixes missing i18n in alt text.

#5 @nacin
14 years ago

This should be esc_attr__ in the future.

#6 @nacin
14 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18931]:

Check post_type_supports before adding comments column to attachments. Translate a string. props johnbillion, SergeyBiryukov. fixes #18644.

Note: See TracTickets for help on using tickets.