Screen Options not working on Post Editor

[Ipstenu]

I tested this with an svn on 18666

Installed a new WordPress install

Went to the Post Editor - formats are visible

Unchecked 'formats' from screen options. Everything works.

Checked 'Auto' for columns from screen options. Everything works. (nb: There was nothing auto-checked for columns)

Go back and check formats .... nothing shows up.

I get the same on my existing (multisite) install at ipstenu.org too, which is why I tested it locally. I'm using twentyeleven, no mods, no plugins, just a bog standard svn up.

[Ipstenu]

Oh. Interesting. I can't add ANYTHING.

I can check anything I want from "Show on screen" but nothing shows on my screen. Once I uncheck a box and refresh, that's it. It's gone.

[solarissmoke]

The problem is caused by [18664]. The !important declaration on .hide-if-js is overriding the inline style set by jQuery.show(), which means the meta box doesn't appear when you check the option. Oops.

Think we have to revert that change.

[solarissmoke]

Remove !important declaration on .hide-if-js etc

[azaozz]

Perhaps we need to use another class when loading hidden postboxes and leave .js .hide-if-js only for stuff we don't want to ever show when js is enabled. Thinking it's handy to be able to do that. Same for .no-js .hide-if-no-js.

[Ipstenu]

The box stays unchecked too (svn r18667). solarissmoke's diff does not correct that.

ETA - That would be because the wp-admin.css file has to be changed too. If you change 'em both, you're fine. Elf drink coffee, THEN comment.

[Ipstenu]

Modify the wp-admin.css file too.

[nacin]

Replying to azaozz:

Perhaps we need to use another class when loading hidden postboxes and leave .js .hide-if-js only for stuff we don't want to ever show when js is enabled. Thinking it's handy to be able to do that. Same for .no-js .hide-if-no-js.

Unfortunately a plugin may be leveraging a similar technique, and the changeset may break things. hide-if-js seems to be simply hide me if there is JS, and hide-if-no-js means the same thing. Doesn't make it permanent.

[azaozz]

In [18668]:

Revert [18664] and handle any similar cases separately, props SergeyBiryukov, fixes #16810, fixes #18656

[azaozz]

Replying to nacin:

Agreed, this also confirms that !important shouldn't be used anywhere :)