WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#18669 closed defect (bug) (fixed)

Media LightBox shows featured image link for CPT's that don't allow thumbnails

Reported by: johnjamesjacoby Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Steps to duplicate:

  • Register a CPT that does not have 'thumbnail' in its $supports array
  • Create a new *post* in your CPT
  • Upload media to your CPT
  • Click "Show Details" on newly uploaded image
  • "Use as featured image" is an available option

See #BB1633 on bbPress trac for original report.

Attachments (1)

18669.patch (1.2 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 SergeyBiryukov3 years ago

  • Description modified (diff)

Corrected bbPress Trac ticket number.

SergeyBiryukov3 years ago

comment:2 SergeyBiryukov3 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.3

comment:3 marv513 years ago

  • Cc marv51 added

comment:4 marv512 years ago

Hi, I reported this bug. The patch Sergey wrote to fix this appears to be very simple.
What is the time frame for something like this to get checked into core? 4.0? never?

comment:5 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19256]:

Don't show 'Use as featured image' in the image insert dialog if the post type does not support thumbnails. Props SergeyBiryukov. fixes #18669

Note: See TracTickets for help on using tickets.