Changes between Initial Version and Version 1 of Ticket #18691, comment 4
- Timestamp:
- 09/18/2011 09:04:06 PM (13 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #18691, comment 4
initial v1 2 2 > I think this patch can be simplified further. The logic is the same as that for post thumbnails, so it can use the same case statement. 3 3 4 I'm tempted to agree, but I'm concerned that a fall-through case statement might not be very clear for others looking at the code later. Considering this coding standard:4 I'm tempted to agree, but I'm concerned that a fall-through case statement might not be very clear for others looking at the code later. Considering [http://codex.wordpress.org/WordPress_Coding_Standards#Clever_Code this coding standard]: 5 5 6 6 > In general, readability is more important than cleverness or brevity.