WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#18700 closed defect (bug) (fixed)

Unnecessary vendor prefixes should be removed

Reported by: helenyhou Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Performance Keywords: has-patch commit
Focuses: Cc:

Description

Some vendor prefixes for some or all properties aren't needed anymore, such as -khtml-* and some -moz-* and -webkit-*. Research and testing needs to be done, especially regarding Safari on iOS.

Some fairly certain ones:

  • all -khtml-*
  • -moz/webkit/o-border-radius
  • -moz/webkit/o-text-shadow
  • ...

Ones that have to stay:

  • *-transform
  • ...

Attachments (5)

18700.patch (14.3 KB) - added by ocean90 3 years ago.
get rid of -khtml
18700.with-text-shadow.patch (14.6 KB) - added by ocean90 3 years ago.
remove vendor prefix for text-shadow
18700.rtl.diff (5.0 KB) - added by ryanimel 3 years ago.
Removes the same vendor prefixes in the RTL stylesheet.
18700.missing-files.diff (5.4 KB) - added by andrewryno 3 years ago.
Get rid of -khtml-* and -moz-border-radius in remaining files.
18700.refresh.patch (5.6 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (14)

@ocean903 years ago

get rid of -khtml

comment:1 @ocean903 years ago

  • Milestone changed from Awaiting Review to 3.3

We need this to make wp-admin.css a bit smaller, see #18314.

comment:2 follow-up: @ocean903 years ago

Border-radius:
https://developer.mozilla.org/en/CSS/border-radius#Browser_compatibility

-webkit is still needed for mobile browsers.

@ocean903 years ago

remove vendor prefix for text-shadow

comment:3 in reply to: ↑ 2 @azaozz3 years ago

Replying to ocean90:

-webkit is still needed for mobile browsers.

Thought we were removing all -moz-border-radius too. Not needed since Gecko 1.8.

comment:4 @azaozz3 years ago

In [18726]:

Remove unnecessary vendor prefixes, props ocean90, see #18700

@ryanimel3 years ago

Removes the same vendor prefixes in the RTL stylesheet.

comment:5 @azaozz3 years ago

In [18962]:

Remove unnecessary vendor prefixes from wp-admin-rtl.css, props ryanimel, see #18700

@andrewryno3 years ago

Get rid of -khtml-* and -moz-border-radius in remaining files.

comment:6 @andrewryno3 years ago

Attached patch should likely get rid of all remaining -khtml-* rules in .dev.css files. Some still remain in non-dev files (like TinyMCE), though. Also twentyten/eleven I think. It also gets rid of -moz-border-radius in other CSS files that were missed.

comment:7 @jane3 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

comment:8 @nacin3 years ago

  • Keywords commit added; dev-feedback removed

Per [18726] and [18962], looks good.

@ocean903 years ago

comment:9 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19203]:

Remove old vendor prefixes. props andrewryno, ocean90, fixes #18700.

Note: See TracTickets for help on using tickets.