WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #18705, comment 5


Ignore:
Timestamp:
10/14/11 22:00:04 (3 years ago)
Author:
crrobi01
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18705, comment 5

    initial v1  
    1 I changed type back to defect. Under certain conditions, home_url() does not point to the page which loads the template home.php 
     1I changed type back to defect. Under certain conditions, home_url() does not point to the page which loads the template home.php. This is a bug. 
    22 
    33The only enhancement here is to create the function front_page_url() because after home_url() is fixed, you lose that functionality. That's not an enhancement, its the preservation of a current feature and the fixing of another. 
     4 
     5EDIT: It's worth nothing that when is_front_page() and is_home() are both true,  
     6front-page.php is loaded instead of home.php. I think this is also a mistake. Suppose a theme has front-page.php for a special banner image template (which doesn't include The Loop) and home.php for the blog. Now the user can never have their blog on the front page. If we load home.php in favor over front-page.php then the user gets all the functionality as before, but also the ability to have their posts page on front if they so choose. No reason not to do this. 
     7 
     8The template hierarchy issue might be worthy of a new ticket, but the front/home dynamic is so confused that I'm just going to leave everything here.