Erroneous admin menu highlighting for non-public post type taxonomies

[johnbillion]

To reproduce:

1. Register a post type with 'public' set to false and 'show_ui' set to true.
2. Register a taxonomy for this post type.
3. Visit the taxonomy management screen for your taxonomy. The 'Posts' top level menu will be highlighted instead of your custom post type.

Changing the 'public' parameter of the post type to true fixes the problem, but obviously does not have the desired outcome.

Sample code:

function add_my_post_type() {

	$post_type_args = array(
		'public'  => false,
		'show_ui' => true,
		'labels'  => array(
			'name'          => 'Foos',
			'singular_name' => 'Foo'
		)
	);
	register_post_type( 'foo', $post_type_args );

	$taxo_args = array(
		'public'  => false,
		'show_ui' => true,
		'labels'  => array(
			'name'          => 'Foo Types',
			'singular_name' => 'Foo Type'
		)
	);
	register_taxonomy( 'foo_type', 'foo', $taxo_args );

}

add_action( 'init', 'add_my_post_type' );

I had a dig but I can't find where the problem is occurring.

[SergeyBiryukov]

WP_Posts_List_Table uses show_ui rather than public when sanitizing $post_type, so we probably should use it in WP_Terms_List_Table as well.

[mitchoyoshitaka]

This change was already made in [19089] as part of #19080.