terms_updated_messages filter

[johnbillion]

In the same vein as #18710 we should add a terms_updated_messages filter for the term management screen. Messages are currently hardcoded as 'Item added', 'Items deleted', etc.

[johnbillion]

Patch which introduces a term_updated_messages filter.

Plugin usage:

function term_updated_messages( $messages ) {
	$messages['foo'] = array(
		0 => '',
		1 => __('Foo added.','foo'),
		2 => __('Foo deleted.','foo'),
		3 => __('Foo updated.','foo'),
		4 => __('Foo not added.','foo'),
		5 => __('Foo not updated.','foo'),
		6 => __('Foos deleted.','foo')
	);
	return $messages;
}
add_filter( 'term_updated_messages', 'foo_updated_messages' );

[wonderboymusic]

Rehab'd the whitespace

[nacin]

In 25143:

Add a terms_updated_messages filter to edit-tags.php, along with taxonomy-specific strings.

props johnbillion.
fixes #18714.

[ocean90]

In 25144:

Replace duplicated lines in [25143] with an assignment. see #18714.

[pavelevap]

We should make difference between "Category" and "Link category". Everytime we use "Link category", for example "Add New Link Category", "New Link Category Name", etc. So, there is different context for "Category" and "Link category" and we should preserve this context also for these messages (even if there will be more strings).

[nacin]

Replying to pavelevap:

We should make difference between "Category" and "Link category". Everytime we use "Link category", for example "Add New Link Category", "New Link Category Name", etc. So, there is different context for "Category" and "Link category" and we should preserve this context also for these messages (even if there will be more strings).

Is it truly necessary? This used to be "Item", with no context at all. And, Links are deprecated in core. Not sure it is worth the effort of translators to translate the new strings, despite there only being a half dozen and pretty short.

[SergeyBiryukov]

I guess I'd prefer to leave [25144] as is. A link category is still a category, and the "Link Categories" screen header provides the context, so it doesn't look like there'll be much confusion.

[pavelevap]

Unfortunately "Item" was better in this case for example for our translation. We are using different meanings for "Category" (Rubrika) and "Link category" (Kategorie odkazů). General word "Item" was better than wrong string. Only other solution for us is combine all these different strings into one, but it is not relevant, because original strings also differ...

Links are deprecated, but still used. When they are removed from core, we can remove also translation.

I suggest reverting back to "Item" or making it right (with Link category context).

[pavelevap]

What about some general strings: "%s added" (and using singular name for taxonomy)? It would be usefull also for custom taxonomies?

[SergeyBiryukov]

We tend to avoid post type and taxonomy names in generic strings, as noted in ticket:17609:3 and ticket:19099:1.

Let's go back to "Item" for link categories then: 18714.2.diff​.

[pavelevap]

+ 1

SergeyBiryukov: Yes, I forgot about broader consequences. Patch is fine for me and there is also no special code for deprecated Links.

[nacin]

In 25158:

Return to 'Item' for term updated messages for the link_category taxonomy.

props SergeyBiryukov, pavelevap.
fixes #18714.