WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#18718 closed defect (bug) (fixed)

No error feedback on non-existent term screen

Reported by: johnbillion Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: minor Version: 3.3
Component: Taxonomy Keywords: has-patch
Focuses: Cc:

Description

If you access the editing screen for a non-existent term you won't see an error message. In addition there's a PHP notice shown in the term description textarea.

Attachments (3)

18718.patch (602 bytes) - added by johnbillion 4 years ago.
18718.2.patch (947 bytes) - added by johnbillion 4 years ago.
18718.3.patch (1006 bytes) - added by johnbillion 4 years ago.

Download all attachments as: .zip

Change History (8)

@johnbillion4 years ago

comment:1 @johnbillion4 years ago

  • Keywords has-patch added

Patch which adds an error message. Uses the same string as the post editing screen so it's not a new string.

@johnbillion4 years ago

comment:2 @johnbillion4 years ago

Updated patch to prevent a bunch of PHP warnings that show up when attempting to save a non-existent term (ie. one that has been deleted since the user started editing it).

@johnbillion4 years ago

comment:3 @johnbillion4 years ago

Fix patch

comment:4 @ocean904 years ago

  • Milestone changed from Awaiting Review to 3.3
NOTICE: wp-admin/edit-tag-form.php:35 - Trying to get property of non-object
NOTICE: wp-admin/edit-tag-form.php:55 - Trying to get property of non-object
NOTICE: wp-admin/edit-tag-form.php:64 - Trying to get property of non-object

comment:5 @ryan4 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [18954]:

Die when attempting to edit non-existent term. Props johnbillion. fixes #18718

Note: See TracTickets for help on using tickets.