Opened 13 years ago
Closed 10 years ago
#18724 closed defect (bug) (fixed)
Non functioning 'paged' input on plugin search
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.0.1 | Priority: | normal |
Severity: | minor | Version: | 3.1 |
Component: | Administration | Keywords: | has-patch fixed-major |
Focuses: | Cc: |
Description (last modified by )
In the WordPress Admin -> Install Themes -> Search ... The page number input is not functional.
Same for plugin search.
Attachments (8)
Change History (40)
#1
@
13 years ago
- Description modified (diff)
- Summary changed from Non functioning 'paged' input on theme search to Non functioning 'paged' input on theme/plugin search
Same for plugin search.
#3
@
13 years ago
- Keywords has-patch added; needs-patch removed
The problem is that the input fields aren't in a <form> tag.
#4
@
13 years ago
@ocean90, thank you. I tested this patch with trunk. It works for the themes and plugins search results.
#7
@
13 years ago
Closed #19128 as duplicate.
Tested your patch at revision 19130 and Theme Search no longer works so I can't test the pagination. Reverted the patch, search works and pagination doesn't.
If it matters, I'm using latest Chrome, Firefox and Safari, haven't tested others. Plugin search appears to work just fine.
#8
follow-up:
↓ 9
@
13 years ago
- Cc johnkleinschmidt added
- Keywords needs-testing added
The issue with ocean90's patch was that he removed/moved the form declarations from the install_theme_search_form function in wp-admin/includes/theme-install.php and the install_search_form function in wp-admin/includes/plugin-install.php. The reason this is a problem is that those functions actually get called two places:
For themes:
- install_themes_dashboard function in wp-admin/includes/theme-install.php
- fired from the install_themes_table_header action in wp-admin/includes/class-wp-theme-install-list-table.php
For plugins:
- install_dashboard function in wp-admin/includes/plugin-install.php
- fired from the install_plugins_table_header action in wp-admin/includes/class-wp-plugin-install-list-table.php
ocean90's solution was to move the form declarations from the search_form functions to the code that fires the actions, but that means that when the dashboard functions get called they don't have the form declaration.
My patch takes a different approach. It seems to me to make more sense to leave the form declarations in the search_form functions and then to move the call to generate pagination within the search_form function. Its a cleaner approach that avoids having to declare the form DOM elements twice.
#9
in reply to:
↑ 8
;
follow-up:
↓ 10
@
13 years ago
Replying to johnkleinschmidt:
My patch takes a different approach. It seems to me to make more sense to leave the form declarations in the search_form functions and then to move the call to generate pagination within the search_form function. Its a cleaner approach that avoids having to declare the form DOM elements twice.
I haven't tried your patch yet, but did/could you also incorporate Jane's request in #19123 for duplicating the entered pagination to the bottom of the screen as well?
#10
in reply to:
↑ 9
@
13 years ago
Replying to DrewAPicture:
I haven't tried your patch yet, but did/could you also incorporate Jane's request in #19123 for duplicating the entered pagination to the bottom of the screen as well?
I did not change the bottom navigation. I thought that there was a feature freeze for 3.3 and 19123 is listed as an enhancement.
#11
@
13 years ago
- Milestone changed from 3.3 to Future Release
Per bug scrub, we're punting the list table search/paging bugs to 3.4, where they will be dealt with in a hopefully consistent manner.
#14
@
10 years ago
- Summary changed from Non functioning 'paged' input on theme/plugin search to Non functioning 'paged' input on plugin search
This seems to no longer affect the theme page thanks to infinite scroll. Perhaps I'm over-simplifying this patch?
#17
@
10 years ago
Patch 18724.diff handles "paged" input similar to the wp-admin/edit-tags.php and wp-admin/edit.php pages.
Patch 18724_kt.patch which is much more simpler also works as desired.
#19
@
10 years ago
Does 18724_kt.patch have any side effects? Or does this look good to everyone? Note: I'd like an esc_attr() added there, even though $tab is safe.
This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.
10 years ago
#22
@
10 years ago
18724_kt.2.patch doesn't work for searches. 18724.diff looks better in this case.
18724.2.patch is based on 18724.diff but removes the useless nonce and checks for $pagenum
<= $total_pages
.
This ticket was mentioned in IRC in #wordpress-dev by nacin1. View the logs.
10 years ago
#25
@
10 years ago
The patch works fine in the plugin search with a small observation noted as a separate item here:
https://core.trac.wordpress.org/ticket/29791
In the theme's search, because of infinite scrolling, the bug does not apply anymore.
#26
@
10 years ago
Patch works for me too, tested on WP 4.0.
I can also confirm the observation from @mariusvetrici with the keyword "press" (https://core.trac.wordpress.org/ticket/29791), but had also another observation.
- A plugin search for "media" resulted in 88 Pages.
- When i enter 88 and hit return i get to page 88, plugins show up, but the total jumps to "of 101" pages.
- Also, the number of found items is going up from 2'615 to 3'008 total items.
#27
@
10 years ago
Upon a further look there is a side effect with the patch, reported by ticket #29796. Currently looking into this.
Non functioning paged input