WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#1873 closed defect (bug) (fixed)

Note on Manage - Categories uses 1 as id, hardcoded

Reported by: shorty114 Owned by: markjaquith
Milestone: Priority: normal
Severity: normal Version: 1.6
Component: Administration Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

Line 142:

    <p><?php printf(__('<strong>Note:</strong><br />Deleting a category does not delete posts from that category, it will just set them back to the default category <strong>%s</strong>.'), get_catname(1)) ?></p>

1 is not necessarily the ID of the default category, since you can change it in Options - Writing. However, we can use get_option:

    <p><?php printf(__('<strong>Note:</strong><br />Deleting a category does not delete posts from that category, it will just set them back to the default category <strong>%s</strong>.'), get_catname(get_option('default_category'))) ?></p>

This is what the patch does.

Attachments (1)

default_cat_id_note.patch (774 bytes) - added by shorty114 8 years ago.
FINAL. Use this one.

Download all attachments as: .zip

Change History (11)

comment:1 shorty1148 years ago

  • Owner changed from anonymous to shorty114

comment:2 shorty1148 years ago

  • Status changed from new to assigned

comment:3 shorty1148 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:4 shorty1148 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5 shorty1148 years ago

  • Keywords bg|has-patch added

shorty1148 years ago

FINAL. Use this one.

comment:6 shorty1148 years ago

Use the more recent one. The other one has other conflicting changes.

comment:7 markjaquith8 years ago

  • Keywords bg|commit added
  • Owner changed from shorty114 to markjaquith
  • Status changed from reopened to new

Good to go.

comment:8 markjaquith8 years ago

  • Status changed from new to assigned

comment:9 matt8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3070]) Real default category, fixes #1873

comment:10 anonymous7 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.