Show revision number for post/pages in Revision list

[midhund]

Sometimes the current revision title is not enough to identify the post/page revisions on the list. So I wish to show the revision number with link to revisions's page.

I have the patch, please review it.

[midhund]

Revision Number Patch #18733

[midhund]

Revision Number in Edit Page

[midhund]

Revision Number in Revision's Page

[midhund]

Revision Number in Revision's Page

[scribu]

This looks like a good idea.

[midhund]

Is this patch submission procedure is correct? missed anything?

[scribu]

The patch submission procedure is correct. Now you just need to get a commiter to commit it.

Before doing that though, please read this: ​http://wpdevel.wordpress.com/2011/09/22/freeze-just-in-time-for-fall/

[nacin]

I don't think the raw post ID is the best number to be presenting here. On many sites this ID will get into the hundreds, thousands, or larger, and they won't be sequential (or maybe not in the correct order, as the screenshot seems to indicate).

Looking at the DB, I don't see a sequential number we would want to use. Like revision 2, revision 3, etc.

[midhund]

@nacin : Yes, I know the raw post id is not sequential, but for the entire blog its should be unique (like this ticket id in Trac). And the user don't get confused when (suppose two posts have revision ids # 22) seeing # 22.
So what you think is the sequential number or unique in entire blog is more user friendly ?

[midhund]

@nacin: or else I can provide sequential number from the field name 'wp_posts.post_name'.
In post_type revision, the value is notated as

25-revision

25-revision-1

..

..

..

25-revision-5

25-revision-6

25-revision-7

for post id 25

for eg: by exploding the 25-revision-5 will get the sequence number of that revision as 5.

hope this makes sense.

[westi]

Adding to the candidate list for the 3.6 Revisions feature work.

[westi]

We should also consider the possibility of a revision change message when we integrate this extra info into the UI and how we might track, capture and display that.

[midhund]

Could you please describe 'revision change message'. Not much clear that.

[adamsilverstein]

this ties right into the ui refresh.

[midhund]

So there was a discussion with @nacin,

The revision id is unique in entire blog,
or
Unique in Post? then each post have revision 1, 2, 3, ...

[midhund]

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ ​http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

[midhund]

QucikRevision

[midhund]

revision meta quick reference

[westi]

Replying to midhund:

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ ​http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

The revisions team are not sure that bringing all the diff details for each revision into the meta box makes sense. Instead we are focusing on improving the useful context info there which helps you get to the right revisions changes to review.

[midhund]

Replying to westi:

Replying to midhund:

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ ​http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

The revisions team are not sure that bringing all the diff details for each revision into the meta box makes sense. Instead we are focusing on improving the useful context info there which helps you get to the right revisions changes to review.

So this version numbering will be available on 3.6 release?

[ocean90]

So, do we still need an ID here?

[adamsilverstein]

no, maybe if should have gravatar though, same as list above.

[adamsilverstein]

Replying to ocean90:

So, do we still need an ID here?

in 18733.diff​

• in post revision meta box ' restored from' line - add gravatar image, remove id, clean up language

before

after

[adamsilverstein]

clean up restored line in revisions post meta box, add gravatar

[ocean90]

18733.2.diff​ fixes a notice in 18733.2.diff and removes the second arg from the human_time_diff() call to prevent a false output on other timezones.

IMO "Previously" should be kept.

[SergeyBiryukov]

We can also remove the translation context in line 33. It's not necessary here, it just partially duplicates the translator's comment.

[ocean90]

In 24156:

Revisions: Remove the ID from the "restored by" line. props adamsilverstein. see #18733.

[ocean90]

Moving this back to Future Release.

azaozz raised a comment on ​IRC which needs to be discussed also.

[adamsilverstein]

Since we reworked the list and it now contains more information, I am closing this as 'won't fix'. I don't really think a numbering scheme would be helpful.

@midhund - if you still think we need revision numbering I would suggest you propose and use a hook in the code that generates the revision list that would allow you to add the info via a plugin. I have started a ticket for adding hooks/filters to revisions, please add your suggestion there: #24908.

I also like your quick revisions idea, that could be added via a plugin as well.