Make WordPress Core

Opened 13 years ago

Closed 10 years ago

Last modified 10 years ago

#18733 closed enhancement (wontfix)

Show revision number for post/pages in Revision list

Reported by: midhund's profile midhund Owned by: midhund's profile midhund
Milestone: Priority: normal
Severity: normal Version: 3.3
Component: Revisions Keywords: needs-patch
Focuses: Cc:

Description

Sometimes the current revision title is not enough to identify the post/page revisions on the list. So I wish to show the revision number with link to revisions's page.

I have the patch, please review it.

Attachments (10)

revision-number.patch (4.8 KB) - added by midhund 13 years ago.
Revision Number Patch #18733
revision_number_in_edit_page_18733.JPG (10.2 KB) - added by midhund 13 years ago.
Revision Number in Edit Page
revision_number_in_revision_page_18733.JPG (22.3 KB) - added by midhund 13 years ago.
Revision Number in Revision's Page
revision_number_in_revision_pageII_18733.JPG (9.7 KB) - added by midhund 13 years ago.
Revision Number in Revision's Page
Qucik Revision.patch (8.3 KB) - added by midhund 11 years ago.
QucikRevision
2Screen1.png (55.7 KB) - added by midhund 11 years ago.
wp_revision_meta_.png (33.8 KB) - added by midhund 11 years ago.
revision meta quick reference
18733.diff (1.6 KB) - added by adamsilverstein 11 years ago.
clean up restored line in revisions post meta box, add gravatar
18733.2.diff (2.2 KB) - added by ocean90 11 years ago.
18733.3.diff (2.1 KB) - added by ocean90 11 years ago.

Download all attachments as: .zip

Change History (34)

@midhund
13 years ago

Revision Number Patch #18733

@midhund
13 years ago

Revision Number in Edit Page

@midhund
13 years ago

Revision Number in Revision's Page

@midhund
13 years ago

Revision Number in Revision's Page

#1 @scribu
13 years ago

This looks like a good idea.

Last edited 13 years ago by scribu (previous) (diff)

#2 @midhund
12 years ago

Is this patch submission procedure is correct? missed anything?

#3 @scribu
12 years ago

The patch submission procedure is correct. Now you just need to get a commiter to commit it.

Before doing that though, please read this: http://wpdevel.wordpress.com/2011/09/22/freeze-just-in-time-for-fall/

#4 @nacin
12 years ago

I don't think the raw post ID is the best number to be presenting here. On many sites this ID will get into the hundreds, thousands, or larger, and they won't be sequential (or maybe not in the correct order, as the screenshot seems to indicate).

Looking at the DB, I don't see a sequential number we would want to use. Like revision 2, revision 3, etc.

#5 @midhund
12 years ago

@nacin : Yes, I know the raw post id is not sequential, but for the entire blog its should be unique (like this ticket id in Trac). And the user don't get confused when (suppose two posts have revision ids # 22) seeing # 22.
So what you think is the sequential number or unique in entire blog is more user friendly ?

Last edited 12 years ago by midhund (previous) (diff)

#6 @midhund
12 years ago

@nacin: or else I can provide sequential number from the field name 'wp_posts.post_name'.
In post_type revision, the value is notated as

25-revision

25-revision-1

..

..

..

25-revision-5

25-revision-6

25-revision-7

for post id 25

for eg: by exploding the 25-revision-5 will get the sequence number of that revision as 5.

hope this makes sense.

#7 @westi
11 years ago

  • Keywords revisions-3.6 added

Adding to the candidate list for the 3.6 Revisions feature work.

#8 @westi
11 years ago

  • Keywords revisions-3.6 removed
  • Milestone changed from Awaiting Review to 3.6

We should also consider the possibility of a revision change message when we integrate this extra info into the UI and how we might track, capture and display that.

#9 @midhund
11 years ago

Could you please describe 'revision change message'. Not much clear that.

#10 @ethitter
11 years ago

  • Cc erick@… added

#11 @adamsilverstein
11 years ago

  • Cc adamsilverstein@… added

this ties right into the ui refresh.

#12 @midhund
11 years ago

So there was a discussion with @nacin,

The revision id is unique in entire blog,
or
Unique in Post? then each post have revision 1, 2, 3, ...

#13 follow-up: @midhund
11 years ago

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

@midhund
11 years ago

QucikRevision

@midhund
11 years ago

@midhund
11 years ago

revision meta quick reference

#14 in reply to: ↑ 13 ; follow-up: @westi
11 years ago

Replying to midhund:

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

The revisions team are not sure that bringing all the diff details for each revision into the meta box makes sense. Instead we are focusing on improving the useful context info there which helps you get to the right revisions changes to review.

#15 in reply to: ↑ 14 @midhund
11 years ago

Replying to westi:

Replying to midhund:

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

The revisions team are not sure that bringing all the diff details for each revision into the meta box makes sense. Instead we are focusing on improving the useful context info there which helps you get to the right revisions changes to review.


So this version numbering will be available on 3.6 release?

#16 follow-up: @ocean90
11 years ago

  • Keywords needs-refresh added; needs-testing removed

So, do we still need an ID here?

http://f.cl.ly/items/3n1k2H3d3j0M1O020b2M/18733.png

#17 @adamsilverstein
11 years ago

no, maybe if should have gravatar though, same as list above.

#18 in reply to: ↑ 16 @adamsilverstein
11 years ago

Replying to ocean90:

So, do we still need an ID here?

http://f.cl.ly/items/3n1k2H3d3j0M1O020b2M/18733.png

in 18733.diff

  • in post revision meta box ' restored from' line - add gravatar image, remove id, clean up language

before

http://f.cl.ly/items/3a2P413v2z3a3M3O1h1i/Screen%20Shot%202013-04-15%20at%2011.45.21%20AM.jpg

after

http://f.cl.ly/items/0V273n331d3p1R3M1M2Q/Screen%20Shot%202013-04-15%20at%2011.50.25%20AM.jpg

@adamsilverstein
11 years ago

clean up restored line in revisions post meta box, add gravatar

@ocean90
11 years ago

#19 @ocean90
11 years ago

  • Keywords needs-refresh removed

18733.2.diff fixes a notice in 18733.2.diff and removes the second arg from the human_time_diff() call to prevent a false output on other timezones.

IMO "Previously" should be kept.

#20 @SergeyBiryukov
11 years ago

We can also remove the translation context in line 33. It's not necessary here, it just partially duplicates the translator's comment.

@ocean90
11 years ago

#21 @ocean90
11 years ago

In 24156:

Revisions: Remove the ID from the "restored by" line. props adamsilverstein. see #18733.

#22 @ocean90
11 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 3.6 to Future Release

Moving this back to Future Release.

azaozz raised a comment on IRC which needs to be discussed also.

#23 @adamsilverstein
10 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Since we reworked the list and it now contains more information, I am closing this as 'won't fix'. I don't really think a numbering scheme would be helpful.

@midhund - if you still think we need revision numbering I would suggest you propose and use a hook in the code that generates the revision list that would allow you to add the info via a plugin. I have started a ticket for adding hooks/filters to revisions, please add your suggestion there: #24908.

I also like your quick revisions idea, that could be added via a plugin as well.

#24 @ocean90
10 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.