WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 6 months ago

Last modified 5 months ago

#18733 closed enhancement (wontfix)

Show revision number for post/pages in Revision list

Reported by: midhund Owned by: midhund
Milestone: Priority: normal
Severity: normal Version: 3.3
Component: Revisions Keywords: needs-patch
Focuses: Cc:

Description

Sometimes the current revision title is not enough to identify the post/page revisions on the list. So I wish to show the revision number with link to revisions's page.

I have the patch, please review it.

Attachments (10)

revision-number.patch (4.8 KB) - added by midhund 3 years ago.
Revision Number Patch #18733
revision_number_in_edit_page_18733.JPG (10.2 KB) - added by midhund 3 years ago.
Revision Number in Edit Page
revision_number_in_revision_page_18733.JPG (22.3 KB) - added by midhund 3 years ago.
Revision Number in Revision's Page
revision_number_in_revision_pageII_18733.JPG (9.7 KB) - added by midhund 3 years ago.
Revision Number in Revision's Page
Qucik Revision.patch (8.3 KB) - added by midhund 17 months ago.
QucikRevision
2Screen1.png (55.7 KB) - added by midhund 17 months ago.
wp_revision_meta_.png (33.8 KB) - added by midhund 17 months ago.
revision meta quick reference
18733.diff (1.6 KB) - added by adamsilverstein 15 months ago.
clean up restored line in revisions post meta box, add gravatar
18733.2.diff (2.2 KB) - added by ocean90 15 months ago.
18733.3.diff (2.1 KB) - added by ocean90 15 months ago.

Download all attachments as: .zip

Change History (34)

midhund3 years ago

Revision Number Patch #18733

midhund3 years ago

Revision Number in Edit Page

midhund3 years ago

Revision Number in Revision's Page

midhund3 years ago

Revision Number in Revision's Page

comment:1 scribu3 years ago

This looks like a good idea.

Last edited 3 years ago by scribu (previous) (diff)

comment:2 midhund3 years ago

Is this patch submission procedure is correct? missed anything?

comment:3 scribu3 years ago

The patch submission procedure is correct. Now you just need to get a commiter to commit it.

Before doing that though, please read this: http://wpdevel.wordpress.com/2011/09/22/freeze-just-in-time-for-fall/

comment:4 nacin3 years ago

I don't think the raw post ID is the best number to be presenting here. On many sites this ID will get into the hundreds, thousands, or larger, and they won't be sequential (or maybe not in the correct order, as the screenshot seems to indicate).

Looking at the DB, I don't see a sequential number we would want to use. Like revision 2, revision 3, etc.

comment:5 midhund3 years ago

@nacin : Yes, I know the raw post id is not sequential, but for the entire blog its should be unique. And the user don't get confused when (suppose two posts have revision ids #22) seeing #22.
So what you think is the sequential number or unique in entire blog is more user friendly ?

Version 0, edited 3 years ago by midhund (next)

comment:6 midhund3 years ago

@nacin: or else I can provide sequential number from the field name 'wp_posts.post_name'.
In post_type revision, the value is notated as

25-revision

25-revision-1

..

..

..

25-revision-5

25-revision-6

25-revision-7

for post id 25

for eg: by exploding the 25-revision-5 will get the sequence number of that revision as 5.

hope this makes sense.

comment:7 westi18 months ago

  • Keywords revisions-3.6 added

Adding to the candidate list for the 3.6 Revisions feature work.

comment:8 westi18 months ago

  • Keywords revisions-3.6 removed
  • Milestone changed from Awaiting Review to 3.6

We should also consider the possibility of a revision change message when we integrate this extra info into the UI and how we might track, capture and display that.

comment:9 midhund18 months ago

Could you please describe 'revision change message'. Not much clear that.

comment:10 ethitter18 months ago

  • Cc erick@… added

comment:11 adamsilverstein18 months ago

  • Cc adamsilverstein@… added

this ties right into the ui refresh.

comment:12 midhund18 months ago

So there was a discussion with @nacin,

The revision id is unique in entire blog,
or
Unique in Post? then each post have revision 1, 2, 3, ...

comment:13 follow-up: midhund17 months ago

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

midhund17 months ago

QucikRevision

midhund17 months ago

midhund17 months ago

revision meta quick reference

comment:14 in reply to: ↑ 13 ; follow-up: westi17 months ago

Replying to midhund:

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

The revisions team are not sure that bringing all the diff details for each revision into the meta box makes sense. Instead we are focusing on improving the useful context info there which helps you get to the right revisions changes to review.

comment:15 in reply to: ↑ 14 midhund16 months ago

Replying to westi:

Replying to midhund:

Please find the attachments, I have some screens to show the revision. Showing the Deleted or Inserted characters doesn't make it simple for average users, (IMHO )I think those this are only for developers. So the user need to check his changed content not the number of characters, etc.[ http://make.wordpress.org/core/2013/01/07/wordpress-3-6-revisions/]

The revisions team are not sure that bringing all the diff details for each revision into the meta box makes sense. Instead we are focusing on improving the useful context info there which helps you get to the right revisions changes to review.


So this version numbering will be available on 3.6 release?

comment:16 follow-up: ocean9015 months ago

  • Keywords needs-refresh added; needs-testing removed

So, do we still need an ID here?

http://f.cl.ly/items/3n1k2H3d3j0M1O020b2M/18733.png

comment:17 adamsilverstein15 months ago

no, maybe if should have gravatar though, same as list above.

comment:18 in reply to: ↑ 16 adamsilverstein15 months ago

Replying to ocean90:

So, do we still need an ID here?

http://f.cl.ly/items/3n1k2H3d3j0M1O020b2M/18733.png

in 18733.diff

  • in post revision meta box ' restored from' line - add gravatar image, remove id, clean up language

before

http://f.cl.ly/items/3a2P413v2z3a3M3O1h1i/Screen%20Shot%202013-04-15%20at%2011.45.21%20AM.jpg

after

http://f.cl.ly/items/0V273n331d3p1R3M1M2Q/Screen%20Shot%202013-04-15%20at%2011.50.25%20AM.jpg

adamsilverstein15 months ago

clean up restored line in revisions post meta box, add gravatar

ocean9015 months ago

comment:19 ocean9015 months ago

  • Keywords needs-refresh removed

18733.2.diff fixes a notice in 18733.2.diff and removes the second arg from the human_time_diff() call to prevent a false output on other timezones.

IMO "Previously" should be kept.

comment:20 SergeyBiryukov15 months ago

We can also remove the translation context in line 33. It's not necessary here, it just partially duplicates the translator's comment.

ocean9015 months ago

comment:21 ocean9015 months ago

In 24156:

Revisions: Remove the ID from the "restored by" line. props adamsilverstein. see #18733.

comment:22 ocean9015 months ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 3.6 to Future Release

Moving this back to Future Release.

azaozz raised a comment on IRC which needs to be discussed also.

comment:23 adamsilverstein6 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

Since we reworked the list and it now contains more information, I am closing this as 'won't fix'. I don't really think a numbering scheme would be helpful.

@midhund - if you still think we need revision numbering I would suggest you propose and use a hook in the code that generates the revision list that would allow you to add the info via a plugin. I have started a ticket for adding hooks/filters to revisions, please add your suggestion there: #24908.

I also like your quick revisions idea, that could be added via a plugin as well.

comment:24 ocean905 months ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.