WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#18740 closed defect (bug) (fixed)

Login form looks janky

Reported by: markjaquith Owned by: markjaquith
Milestone: 3.3 Priority: low
Severity: minor Version: 3.3
Component: UI Keywords: has-patch commit
Focuses: Cc:

Description

It used to look like this:

http://f.cl.ly/items/2g3W3G201Y0t003Q272A/Screen%20Shot%202011-09-21%20at%202.36.08%20PM.png

Now it looks like this:

http://f.cl.ly/items/3a1a1V2o2A3z1n3N1f3F/Screen%20Shot%202011-09-21%20at%202.54.23%20PM.png

The padding and the symmetry is all wrong. Nothing lines up correctly.

Attachments (7)

18740.diff (831 bytes) - added by markjaquith 3 years ago.
18740.2.diff (904 bytes) - added by SergeyBiryukov 2 years ago.
18740.wp32.png (22.3 KB) - added by SergeyBiryukov 2 years ago.
Login form in 3.2
18740.wp33-trunk.png (22.7 KB) - added by SergeyBiryukov 2 years ago.
Login form in 3.3-trunk
18740.diff.png (22.4 KB) - added by SergeyBiryukov 2 years ago.
With 18740.diff
18740.2.diff.png (22.5 KB) - added by SergeyBiryukov 2 years ago.
With 18740.2.diff
18740.strength-indicator.png (29.2 KB) - added by SergeyBiryukov 2 years ago.
Reset Password form with 18740.2.diff

Download all attachments as: .zip

Change History (16)

markjaquith3 years ago

comment:1 markjaquith3 years ago

After the patch, it looks like this:

http://cl.ly/2N0t2h3h0M3S3t2n3834/Screen_Shot_2011-09-21_at_3.30.22_PM.png

comment:2 markjaquith3 years ago

  • Component changed from General to UI
  • Milestone changed from Awaiting Review to 3.3
  • Priority changed from normal to low
  • Resolution set to fixed
  • Severity changed from normal to minor
  • Status changed from new to closed
  • Version set to 3.3

One of the recent CSS cleanups fixed it!

comment:3 SergeyBiryukov3 years ago

Hmm. Updated to r18796, cleared the cache, still see the same as on "Now it looks like this" screenshot.

Checked in Firefox 7, Chrome 14, Opera 11.51.

comment:4 SergeyBiryukov2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This wasn't fixed. See also #19201.

comment:5 nacin2 years ago

Closed #19201 as a duplicate.

comment:6 aaroncampbell2 years ago

  • Keywords has-patch commit added

The patch still works - it even still applies (offset by 350 lines, but it applies). I tested it in the latest Chrome, Firefox, Internet Explorer, Safari, and Opera on Windows 7 and in the latest Chromium, Firefox, and Opera on Ubuntu. In all cases the patch:

  1. Tightens vertical spacing between username, password, and remember me sections.
  2. Extends the text inputs so that the right side of the inputs lines up with the right side of the Log In button.

SergeyBiryukov2 years ago

SergeyBiryukov2 years ago

Login form in 3.2

SergeyBiryukov2 years ago

Login form in 3.3-trunk

SergeyBiryukov2 years ago

With 18740.diff

SergeyBiryukov2 years ago

With 18740.2.diff

SergeyBiryukov2 years ago

Reset Password form with 18740.2.diff

comment:7 SergeyBiryukov2 years ago

18740.2.diff makes login form look more like in 3.2 (see the screenshots). Also fixes strength indicator in Reset Password form (#19201).

comment:8 markjaquith2 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from reopened to closed

In [19313]:

Fix various login form and password strength meter CSS issues. fixes #18740. see #19201. props Sergey Biryukov.

Note: See TracTickets for help on using tickets.