WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#18762 new defect (bug)

Pagination does not work correctly on walker in reverse order.

Reported by: gburtini Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.2.1
Component: Comments Keywords: has-patch
Focuses: Cc:

Description

Steps to reproduce:

  1. Go to Discussion and change Comments should be displayed with the comments at the top of each page to "newer" (that is, set comment_order='desc').
  2. Make sure your theme is paginating comments. Make sure you have more than the page limit of comments.
  3. Note that the first page does not actually contain the newest comments (they're off by a page, or perhaps they're just sorted in one way for the pagination and a different way for the inner page sort).

If you check out the $start, $oldstart and $end variables, the way it was written before the patch, $start gets set to 11 (page limit + 1) on page = 1, the way it is written after the patch, start is 0, as it should be.

All I've done is swapped the order of $start and $end being updated. This fixes the starting point. This needs to be tested in more detail before actually deploying it, but there is definitely a pretty serious bug here.

Attachments (1)

fix_reverse_order_pagination.diff (895 bytes) - added by gburtini 3 years ago.
Patch to fix strange sort order.

Download all attachments as: .zip

Change History (3)

gburtini3 years ago

Patch to fix strange sort order.

comment:1 SergeyBiryukov3 years ago

  • Keywords has-patch added

comment:2 coffee2code2 years ago

  • Version set to 3.2.1
Note: See TracTickets for help on using tickets.