WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#18770 closed defect (bug) (fixed)

Make repair.php fully translatable

Reported by: ocean90 Owned by: ryan
Priority: low Milestone: 3.4
Component: I18N Version: 3.3
Severity: minor Keywords: has-patch
Cc: Focuses:

Description


Attachments (3)

18770.patch​ (3.7 KB ) - added by ocean90 15 years ago.
18770.2.patch​ (861 bytes ) - added by ocean90 15 years ago.
18770-zeo.diff​ (6.6 KB ) - added by Zeo 15 years ago.
repair.php l10n tweak and more

Download all attachments as: .zip

Change History (15)

@ocean90
15 years ago

#1 @ocean90
15 years ago

  • Version → 2.9

#2 @ryan
15 years ago

  • Owner set to ryan
  • Resolution → fixed
  • Status new → closed

In [19070]:

Make repair.php fully translatable. Props ocean90. fixes #18770

#3 @ocean90
15 years ago

18770.2.patch will fix my placeholder fail. Sry.

@ocean90
15 years ago

#4 @ryan
15 years ago

In [19073]:

gettext fix. Props ocean90. fixes #18770

#5 @Zeo
15 years ago

  • Keywords dev-feedback added
  • Resolution fixed
  • Status closed → reopened
  • Version 2.9

Sorry for re-opening this ticket.

In my patch:

  • Add missing paragraph
  • Add missing semicolon (what's up with the non-breaking space galore)
  • Make support forum URL translatable
  • Unnecessary double spacing in strings

#6 @ryan
15 years ago

  • Milestone 3.3 → Future Release

We limit use of get_option() in repair.php because repair.php is usually visited when there is a problem with the options table.

@Zeo
15 years ago

repair.php l10n tweak and more

#7 @Zeo
15 years ago

@ryan patch refresh.

#8 @SergeyBiryukov
15 years ago

18770-zeo.diff​ seems good for 3.3? Only strings/markup fixes. At least "Make support forum URL translatable" part would be nice.

#9 @Zeo
15 years ago

@SergeyBiryukov true that. Since it's not string freeze yet and there's a lot of string changes activity in #19020.

#10 @ocean90
15 years ago

  • Keywords dev-feedback removed
  • Milestone Future Release → 3.4
  • Version → 3.3

#11 @nacin
15 years ago

  • Resolution → fixed
  • Status reopened → closed

In [19757]:

Formatting and i18n cleanup of repair.php. props zeo for initial patch. fixes #18770.

#12 @nacin
15 years ago

I think I caught everything at this point.

Note: See TracTickets for help on using tickets.