get_locale() should check site option in multisite even when WP_INSTALLING

[nacin]

In multisite, get_locale() will check get_option('WPLANG') and then get_site_option('WPLANG'). We skip both when WP_INSTALLING (i.e. blog activation), but we should only skip the blog option at that point.

Follow up to a comment of mine in #14553.

[SergeyBiryukov]

Related: #18688

[nacin]

In [19059]:

Check get_site_option(WPLANG) when WP_INSTALLING in mulitiste, just not the blog's option. fixes #18783.

[foxinni]

I got a plugin running on a multisite and there is definitely something up with the translation.

I tracked the problem down to the WPLANG option in http://localhost/<subsite>/wp-admin/options.php just being empty. I tried to update it, but it keeps reverting to blank. So down the line the issue starts with get_locale() looking for the WPLANG value in the site_options and then defaulting back to en_US because it's not picking it up from the wp-config.php defined WPLANG.

I'm assuming that the defined WPLANG in the wp-config.php does not apply in multi site instances.

I'm gonna write a filter to fix this, as there is ample hooks for that.

[foxinni]

Simple filter to force the locale:

function modify_locale(){
    return 'de_DE';
}
add_filter('locale','modify_locale');

[SergeyBiryukov]

Replying to foxinni:

This ticket was closed on a completed milestone. Please open a new one.