Changes between Initial Version and Version 1 of Ticket #18792, comment 6
- Timestamp:
- 09/17/2013 09:05:36 AM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #18792, comment 6
initial v1 16 16 I checked the ClearAddresses method, hoping it was clearing Sender. But it's not. Not sure if it should. Perhaps there needs to be a ClearFrom method added to the PHPMailer class? 17 17 18 I see that Sender does need to be reset in, because it only gets set in SetFrom if it's currently empty.18 I see that Sender does indeed need to be reset, because it only gets set in SetFrom if it's currently empty. 19 19 20 20 {{{ … … 25 25 }}} 26 26 27 Also, the original patch provided by pigster, who opened this ticket also still remains. Specifically, PHPMailer's internal class properties are being accessed directly in the following code, inadvertently preventing property Sender from ever being set ...27 Also, the original patch provided by pigster, who opened this ticket, also still remains. Specifically, PHPMailer's internal class properties are being accessed directly in the following code, inadvertently preventing property Sender from ever being set ... 28 28 29 29 {{{ … … 33 33 }}} 34 34 35 I found and fixed that problem myself, just before locating this bug ticket, unsurprisingly in the precise same way as pigster, as follows...35 I found and fixed that problem myself, just before locating this bug ticket, unsurprisingly in the precise same way as pigster, like so ... 36 36 37 37 {{{ … … 40 40 }}} 41 41 42 It works, albeit not accounting for the looping issue, noted by KevinHamilton, above.42 It works, albeit not accounting for the looping issue, noted above by KevinHamilton. 43 43 44 Did I mention that this bug has been around for at least two years and has causes a massive amount of trouble in terms of mail getting tagged as spam and what not for a very, very long time? Surely that is a serious thing, no? Perplexed, I am. *shrug*44 Did I mention that this bug has been around for at least two years and has surely caused a massive amount of trouble in terms of mail getting tagged as spam and what not, for a very, very long time? ''Surely'' that is a serious thing to the developers? Perplexed, I am. *shrug* Perhaps I'm missing something. 45 45 46 Has this issue been addressed already development versions 3.7 or v3.8, perhaps? How far away are those from release anyway? Where would I go to find that out myself?46 Has this issue been addressed already in development versions 3.7 or v3.8? How far away are those from release anyway? Where would I go to find that out myself? 47 47 48 Can I contribute code or a patch directly, have it verified and actually included in v3.6.2 somehow? I've read the docs. I know how to submit bug reports, patches and more. But not how to actually get this thing sorted. "Somewhat frustrating.", said the new kid on the block.48 Can I contribute code or a patch directly, have it verified and included in v3.6.2 somehow? I've read the docs. Whilst I know how to submit bug reports, patches and more. But not how to actually get this thing sorted. "Somewhat frustrating.", said the new kid on the block. (I'll read the docs again, lest I missed something.) 49 49 50 In the meantime, is there already plugin that addresses this fault specifically? I have not been able to find one -- though there are several that go around the problem it causes, evidently not realising where the original fault actually lies. (The Xmail plugin, for one, uses an incredibly convoluted and unnecessarily complex method to get around this bug. Clever ... but oh so unneeded, if this simple error were just fixed. :-/ ) Should I go to the effort of writing a plugin that fixes this? (At first glance, it doesn't seem likely that a plugin could wedge into the right places to do such a thing. I don't want to write another Xmail.)50 In the meantime, is there already plugin that addresses this fault specifically? I have not been able to find one -- though there are several that go around the problem this bug causes, evidently not realising where the original fault actually lies. (The Xmail plugin, for one, uses an incredibly convoluted method to get around this bug. Clever ... but oh so unneeded, if this simple error were simply fixed, already. :-/ ) Should I go to the effort of writing a plugin that fixes this, "properly"? At first glance, that doesn't seem likely possible. 51 51 52 52 --OR-- Is wp_mail() deprecated anyway -- or should it be, in favor of using PHPMailer class directly in all plugins from now on? Frankly, I'm too new to Wordpress to even guess. Any and all comments welcomed, either here or to my email (assuming you get to see that?) … … 54 54 Gruvin. 55 55 56