Opened 12 years ago
Closed 12 years ago
#18794 closed defect (bug) (fixed)
Twentyeleven templates do not properly call the loop
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.3 | Priority: | high |
Severity: | normal | Version: | 3.2.1 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Is there any particular reason that twentyeleven does not use a proper loop? Many (if not all) of the templates use
the_post()
rather than
if ( have_posts() ) : the_post();
thus defining $wp_query->in_the_loop
as always true.
Attachments (1)
Change History (8)
#2
@
12 years ago
- Cc michael@… added
- Keywords has-patch added
I uploaded 18794.diff which seems to fix this issue in all templates with partial loops. Please let me know if I missed anything.
#5
@
12 years ago
- Keywords dev-feedback removed
- Milestone changed from Awaiting Review to 3.3
- Priority changed from normal to high
Note: See
TracTickets for help on using
tickets.
Some templates do indeed have this problem.
This is something we fixed with Twenty Ten, so it's rather annoying it got through again.
image.php, page.php, showcase.php, and sidebar-page.php are all affected. single.php is not, in particular.
Previously: #13279.