Opened 9 years ago
Closed 9 years ago
#18796 closed defect (bug) (fixed)
thickbox.css needs display:none
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.3 | Priority: | normal |
Severity: | normal | Version: | 3.3 |
Component: | External Libraries | Keywords: | thickbox has-patch |
Focuses: | Cc: |
Description
In thickbox.css display:none was replaced by visibility:hidden (line 52). The thickbox will not be displayed if there is no property 'display', because thickbox checks the property 'display' (line 208 in thickbox.js).
If you use e.g. tb_show in a javascript, it will not show the thickbox.
Attachments (4)
Change History (15)
#4
follow-up:
↓ 5
@
9 years ago
- Keywords has-patch added
18796.patch restores display: none
.
But then I've noticed there's a small delay before #TB_window
fully opens, leading to overlapping for some part of a second (see the screenshot).
18796.2.patch switches the remaining display
references to visibility
. Looks like the delay is not happening in that case.
#5
in reply to:
↑ 4
@
9 years ago
Replying to SergeyBiryukov:
But then I've noticed there's a small delay before
#TB_window
fully opens, leading to overlapping for some part of a second (see the screenshot).
18796.2.patch switches the remaining
display
references tovisibility
. Looks like the delay is not happening in that case.
Do you try '.show()' instead of 'viibility' or 'display'? Maybe this fix your problem with overlapping.
thickbox.18796.patch restore 'display: none' and replace '.css('display', 'block')' with '.show()'.
#6
@
9 years ago
Still see the overlapping in Firefox 7 with thickbox.18796.patch. According to jQuery docs, .show()
just sets display: block
internally.
Also, there's a typo in thickbox.css
, should be display: none
.
#7
@
9 years ago
This was changed because the uploader had problems initializing in a hidden iframe in some browsers. Seems 18796.2.patch is the proper solution here and the overlapping can probably be solved with css.
#9
@
9 years ago
- Resolution set to fixed
- Status changed from new to closed
I tested 18796.2.patch with some of my plugins. All work fine. I think we can close the ticket.
I can confirm this. Have been wondering why my plugin that calls tb_show() through its own call does not work with trunk, but with 3.2.1.
Relevant change seems to have been introduced in [18482].